Hibernate ORM tries to connect to the database on startup even with schema validation disabled #48130

lucamolteni · 2025-05-29T12:18:42Z

To be merged after #41310 as it's based on @yrodiere Hibernate 7 branch, creating a Draft PR

Based on the original work of https://github.com/xdev-software https://github.com/quarkusio/quarkus/pull/47695/files

This handles some of the issues addressed in #30002 (comment)

Done:

A start-offline setting
Code that turns this setting into hibernate.boot.allow_jdbc_metadata_access=*.
io.quarkus.hibernate.orm.runtime.HibernateOrmRuntimeConfigPersistenceUnit.HibernateOrmConfigPersistenceUnitDatabase#versionCheckEnabled should default to false when asked to start offline, and lead to an exception with a clear message when it's explicitly set to true while starting offline.
io.quarkus.hibernate.orm.runtime.HibernateOrmRuntimeConfigPersistenceUnit.HibernateOrmConfigPersistenceUnitSchemaManagement#strategy should default to none when asked to start offline, and lead to an exception with a clear message when it's explicitly set to anything else while starting offline.
A few tests (for both ORM and reactive)

Except for the one for dev services for a few reasons:

I haven't found a way to test it properly (yet)
I could find an easy way to get the runtime configuration in HibernateOrmDevServicesProcessor
I'm not entirely sure the offline mode should change the behaviour of dev mode. I think it's for deployment scenarios.

These internals are changing in Hibernate ORM 7

Because: 1. We currently disallow this for identifier generators only through a custom initializer for the identifier generator factory service, but that service is disappearing in Hibernate ORM 7.0.0.Beta1, leaving us only the setting `hibernate.cdi.extensions`. to disallow CDI for identifier generators -- and anything else that impacts metadata creation. 2. This is needed for quarkusio#40897, which will move more of metadata creation to build time -- where CDI is just not available. 3. Implementations of affected components needing access to CDI at runtime (so not during metadata creation) can still do so by calling `Arc.container()` to retrieve the relevant beans.

…equired dependencies With Derby moving to hibernate-community-dialects, Quarkus will need to add this dependency automatically.

…ilder Some of these changes probably pre-date Hibernate ORM 7.0, we just forgot to implement them.

Co-Authored-By: Jan Schatteman <[email protected]>

See https://docs.jboss.org/hibernate/orm/7.0/migration-guide/migration-guide.html#create-query See https://hibernate.atlassian.net/browse/HHH-18584

And remove Hibernate Commons Annotations, which isn't needed by any Hibernate project anymore.

…ibernate Search 8.0.0.Beta1

* Including verification for checkVersion * Including asserts on schema management

quarkus-bot · 2025-05-29T12:19:49Z

/cc @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search)

yrodiere

Thanks! LGTM overall, though I have concerns about the temporary table thing -- see below.

To be merged after #41310 as it's based on @yrodiere Hibernate 7 branch, creating a Draft PR

FWIW if you're only going to address #30002 (and not #13522) in this PR, you can probably base your work on main. I don't expect anything here to require the upgrade to ORM 7, and this would allow merging your PR more quickly.

yrodiere · 2025-06-02T08:54:24Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

I'm not entirely sure the offline mode should change the behaviour of dev mode. I think it's for deployment scenarios.

It definitely should IMO. As a rule, explicit configuration should never be ignored.

If people want Hibernate ORM to start offline in every mode, that's fine, and it can definitely make sense if they don't use dev services. Even when using dev services, I personally would want my app to behave as closely as possible to the way it will behave in production.

If people want Hibernate ORM to start offline only in prod mode, they can use %prod.quarkus.hibernate-orm.start-offline = true.

yrodiere · 2025-06-02T10:22:23Z

...loyment/src/test/java/io/quarkus/hibernate/orm/offline/StartOfflineSchemaManagementTest.java

+                    throwable -> assertThat(throwable)
+                            .hasNoSuppressedExceptions()
+                            .hasMessageContaining(
+                                    "Version check `quarkus.hibernate-orm.schema-management.strategy` cannot be any different than `none` when using offline mode `quarkus.hibernate-orm.database.start-offline=true`"));


Wording seems strange, especially the "any different"... Also it has nothing to do with the version check?

I'd recommend something like this:

Suggested change

"Version check `quarkus.hibernate-orm.schema-management.strategy` cannot be any different than `none` when using offline mode `quarkus.hibernate-orm.database.start-offline=true`"));

"Schema management strategy `quarkus.hibernate-orm.schema-management.strategy` only be set to `none` when using offline mode `quarkus.hibernate-orm.database.start-offline=true`"));

yrodiere · 2025-06-02T10:24:51Z

...src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java

        @WithName("version-check.enabled")
-        @ConfigDocDefault("`true` if the dialect was set automatically by Quarkus, `false` if it was set explicitly")
+        @ConfigDocDefault("`true` if the dialect was set automatically by Quarkus, `false` if it was set explicitly, `false` in offlineMode")


Okay, three different possibilities is starting to get ambiguous :)

Maybe:

Suggested change

@ConfigDocDefault("`true` if the dialect was set automatically by Quarkus, `false` if it was set explicitly, `false` in offlineMode")

@ConfigDocDefault("`false` if the dialect was set explicitly or if starting offline (see `start-offline`), `true` otherwise")

yrodiere · 2025-06-02T10:27:02Z

...src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java

        Optional<Boolean> versionCheckEnabled();
+
+        /**
+         * This value will avoid connecting to a database to fetch JDBC metadata.


I think at this point it's more about disabling/disallowing these other features? Or at least that will probably be more meaningful to application developers.

Suggested change

* This value will avoid connecting to a database to fetch JDBC metadata.

* Instructs Hibernate ORM to avoid connecting to the database on startup (for schema management, temporary table creation, DB version checking, ...).

* <p>

yrodiere · 2025-06-02T10:54:20Z

...ime/src/main/java/io/quarkus/hibernate/orm/runtime/FastBootHibernatePersistenceProvider.java

+        // Allow detection of driver/database capabilities on runtime init if required
+        // (was disabled during static init)
+        runtimeSettingsBuilder.put(JdbcSettings.ALLOW_METADATA_ON_BOOT, !startsOffline);
+        runtimeSettingsBuilder.put(GlobalTemporaryTableStrategy.CREATE_ID_TABLES, !startsOffline);


This will probably need more thoughts. If we don't create the tables, presumably something will go wrong when those tables are used.

So:

When starting offline, should we consider simply overriding the temporary table kind to local? AFAIK H2 supports local temporary tables, and that was even the default before ORM 6.6: https://hibernate.atlassian.net/browse/HHH-18146 .

If instead we keep "persistent" temporary tables:

Should we document this in Quarkus, and explain how to work around the problem?

Should we set the other setting, another setting, DROP_ID_TABLES, to false as well? If someone else created the tables, they probably wouldn't want us to drop them...

Should probably report the problem to Hibernate ORM, so that "temporary" table creation is integrated into schema management (hbm2ddl)? That makes a lot more sense to me...

I'd personally go with the first option, which puts the problem away in the short term, and file a ticket about investigating the second option later.. Because regardless,

Note: Keep in mind the "temporary tables" are only used in some specific scenarios, so existing tests may not detect any problems, yet there will be problems.

yrodiere and others added 20 commits May 20, 2025 14:15

Remove some dead code in Panache using Hibernate ORM internals

8248739

These internals are changing in Hibernate ORM 7

Upgrade to Hibernate ORM 7.0.0.Alpha3

6744eac

Upgrade to Hibernate ORM 7.0.0.Beta1

4d583f2

Make Hibernate ORM and jdbc-derby extensions work without any other r…

1703507

…equired dependencies With Derby moving to hibernate-community-dialects, Quarkus will need to add this dependency automatically.

Upgrade to Hibernate ORM 7.0.0.Beta3 / Reactive 3.0.0.Beta1

340d64b

Adapt QuarkusStrategySelectorBuilder to changes in StrategySelectorBu…

a0505c6

…ilder Some of these changes probably pre-date Hibernate ORM 7.0, we just forgot to implement them.

Work around https://hibernate.atlassian.net/browse/HHH-19033

40ac7d9

Upgrade to Hibernate ORM 7.0.0.Beta4 / Reactive 3.0.0.Beta2

2cd3179

Co-Authored-By: Jan Schatteman <[email protected]>

Take into account feature removal HHH-18584 in tests

71bd8e6

See https://docs.jboss.org/hibernate/orm/7.0/migration-guide/migration-guide.html#create-query See https://hibernate.atlassian.net/browse/HHH-18584

Upgrade to Hibernate Search 8.0.0.Alpha1

ed7d5da

And remove Hibernate Commons Annotations, which isn't needed by any Hibernate project anymore.

Upgrade to Hibernate Search 8.0.0.Alpha2

05b07e1

Upgrade to Hibernate ORM 7.0.0.Beta5 / Hibernate Reactive 3.0.0.Beta3

e1af27b

Upgrade to Hibernate Search 8.0.0.Alpha3

2fb2e72

Upgrade to Hibernate ORM 7.0.0.CR1 / Hibernate Reactive 3.0.0.CR1 / H…

815681d

…ibernate Search 8.0.0.Beta1

Upgrade to Hibernate ORM 7.0.0.CR2 / Hibernate Reactive 3.0.0.CR2

9a0bb7f

Upgrade to Hibernate ORM 7.0.0.Final / Hibernate Reactive 3.0.0.Final

30a081d

Make it possible to start without connecting to the database

6f91e02

StartOfflineTest

1970dc3

* Including verification for checkVersion * Including asserts on schema management

Same check in Hibernate Reactive

60a7f70

lucamolteni requested review from yrodiere and gsmet and removed request for yrodiere May 29, 2025 12:19

quarkus-bot bot added area/panache area/spring Issues relating to the Spring integration labels May 29, 2025

lucamolteni mentioned this pull request May 29, 2025

Hibernate ORM tries to connect to the database on startup even with schema validation disabled #30002

Open

AB-xdev mentioned this pull request Jun 2, 2025

Make it possible to start without connecting to the database #47695

Closed

yrodiere requested changes Jun 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hibernate ORM tries to connect to the database on startup even with schema validation disabled #48130

Hibernate ORM tries to connect to the database on startup even with schema validation disabled #48130

Uh oh!

lucamolteni commented May 29, 2025

Uh oh!

quarkus-bot bot commented May 29, 2025

Uh oh!

yrodiere left a comment

Uh oh!

yrodiere Jun 2, 2025

Uh oh!

yrodiere Jun 2, 2025

Uh oh!

yrodiere Jun 2, 2025

Uh oh!

yrodiere Jun 2, 2025

Uh oh!

yrodiere Jun 2, 2025

Uh oh!

Uh oh!

	"Version check `quarkus.hibernate-orm.schema-management.strategy` cannot be any different than `none` when using offline mode `quarkus.hibernate-orm.database.start-offline=true`"));
	"Schema management strategy `quarkus.hibernate-orm.schema-management.strategy` only be set to `none` when using offline mode `quarkus.hibernate-orm.database.start-offline=true`"));

	@ConfigDocDefault("`true` if the dialect was set automatically by Quarkus, `false` if it was set explicitly, `false` in offlineMode")
	@ConfigDocDefault("`false` if the dialect was set explicitly or if starting offline (see `start-offline`), `true` otherwise")

	* This value will avoid connecting to a database to fetch JDBC metadata.
	* Instructs Hibernate ORM to avoid connecting to the database on startup (for schema management, temporary table creation, DB version checking, ...).
	* <p>

Hibernate ORM tries to connect to the database on startup even with schema validation disabled #48130

Are you sure you want to change the base?

Hibernate ORM tries to connect to the database on startup even with schema validation disabled #48130

Uh oh!

Conversation

lucamolteni commented May 29, 2025

Done:

Uh oh!

quarkus-bot bot commented May 29, 2025

Uh oh!

yrodiere left a comment

Choose a reason for hiding this comment

Uh oh!

yrodiere Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!