Skip to content

[FEA] xfail currently failing pandas-test failures to enable CI pass/fail for the job #18569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
galipremsagar opened this issue Apr 24, 2025 · 0 comments · Fixed by #18641
Closed

[FEA] xfail currently failing pandas-test failures to enable CI pass/fail for the job #18569

galipremsagar opened this issue Apr 24, 2025 · 0 comments · Fixed by #18641
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Describe the bug
The current pandas test suite which is only run against latest version of cudf and pandas fails with a pass/fail rate. We want to enable pass/fail on this job by xfailing all current failures.
@galipremsagar galipremsagar added the bug Something isn't working label Apr 24, 2025
@galipremsagar galipremsagar self-assigned this Apr 24, 2025
@galipremsagar galipremsagar added the Python Affects Python cuDF API. label Apr 24, 2025
@galipremsagar galipremsagar mentioned this issue May 1, 2025
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue May 1, 2025
@galipremsagar
xfail all known errors in pandas-test suite (#18612)
bc552b5 
Achieves 90% of #18569 

This PR programatically `xfails` all known errors that show up in pandas test suite.

branch-25.06:

```
= 13298 failed, 199023 passed, 6633 skipped, 1655 xfailed, 82 xpassed, 17813 warnings, 96 errors in 4804.61s (1:20:04) =
```


This PR:

```
= 1629 failed, 198893 passed, 6633 skipped, 13400 xfailed, 84 xpassed, 17771 warnings, 4 errors in 2240.08s (0:37:20) =
```

I plan on doing follow-up PRs for the rest 1.6k failures which seem to be inconsistent results that `cudf` returns. Once we hit that mark, we should be able to fully enable pass/fail status on the job.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - https://github.com/brandon-b-miller

URL: #18612
@galipremsagar galipremsagar mentioned this issue May 2, 2025
Merged
3 tasks
@vyasr vyasr mentioned this issue May 6, 2025
Closed
rapids-bot bot pushed a commit that referenced this issue May 8, 2025
@galipremsagar
Skip all known pytest failures in pandas-tests (#18641)
e0ab818 
Resolves: #18569
This PR enables strict pass/fail for `pandas-tests` job by skipping all know failures.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #18641
@github-project-automation github-project-automation bot moved this from Todo to Done in cuDF Python May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip all known pytest failures in pandas-tests galipremsagar/cudf
1 participant
@galipremsagar