xfail all known errors in pandas-test suite #18612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
github-actions
bot
added
Python
brandon-b-miller
approved these changes
May 1, 2025
Matt711
reviewed
May 1, 2025
| "\"label=Interval(1, 4, closed='right') not in index\"", | ||
| "\"label=Timestamp('2019-01-01 00:00:00') not in index\"", | ||
| "\"label=Timedelta('1 days 00:00:00') not in index\"", | ||
| "7", |
There was a problem hiding this comment.
This is too generic, no? Can we add the full error message?
There was a problem hiding this comment.
The error itself is KeyError: 7, nothing more than that. More information can be extracted if we inspect the stack-trace also programmatically, but that's overkill for something like this.
|
/merge |
galipremsagar
added
the
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Achieves 90% of #18569
This PR programatically
xfailsall known errors that show up in pandas test suite.branch-25.06:
This PR:
I plan on doing follow-up PRs for the rest 1.6k failures which seem to be inconsistent results that
cudfreturns. Once we hit that mark, we should be able to fully enable pass/fail status on the job.Checklist