Skip to content

Mononoki Nerd Font Needs Updating #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
redactedscribe opened this issue Feb 4, 2021 · 14 comments
Closed

Mononoki Nerd Font Needs Updating #575

redactedscribe opened this issue Feb 4, 2021 · 14 comments
Labels
❲Aa❳ update font version bump
Milestone
v2.3.0

Comments

@redactedscribe
Copy link

🎯 Subject of the issue

The source madmalik/mononoki recently updated Mononoki on the 31 Jan 2021 ("updated character set"). Last release was 10 Jun 2016. The nerd font could be updated at some point.
@redactedscribe
Copy link
Author

The font's updates should now be included due to c5b8b55. Thanks!

@Finii
Copy link
Collaborator

Finii commented Aug 26, 2022

I fear this has not been updated, there was no PR for it.

Screenshot_20220826_153415

Lets create one for 2.3.0_RC (later).

@Finii Finii reopened this Aug 26, 2022
@Finii Finii added this to the v2.3.0 milestone Aug 26, 2022
@redactedscribe
Copy link
Author

redactedscribe commented Aug 26, 2022 •
edited
Loading

I fear this has not been updated, there was no PR for it.

@Finii My Nerd Fonts are managed by a Scoop bucket and it just pushed out an update for many of the NF fonts, Mononoki included, so I assumed it had been: matthewjberger/scoop-nerd-fonts@dfded9f. After installing the font and restarting the system, at least something has changed because the font in VS Code/Codium now displays double as wide as before:

VSCodium

Not sure why, but other programs seem to be unaffected by this bug, and it can be essentially mitigated in Code/Codium by using editor.letterSpacing": -5.

Also, the other NF fonts just updated display the same double-wide behaviour: Switching to Consolas (a non-NF font) renders with the correct letter spacing. Maybe Code/Codium has a preference that I've altered which is affecting the NF fonts' rendering, but why not Consolas for example? Hmm.

@Finii Finii mentioned this issue Aug 26, 2022
Closed
@Finii
Copy link
Collaborator

Finii commented Aug 26, 2022

Thanks for reporting the bug so quickly!

I hope v2.2.1 will hold up to your expectations.

Added comment to the v2.2.0:

A bugfix release is already in the making: 2.2.1, but that will take about 5 hours until all fonts have been re-patched.

The new release will be https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.2.1 if ready (i.e. ~27-08-2022 00:00:00 UTC). :clock1:

@Finii
Copy link
Collaborator

Finii commented Jan 17, 2023

@madmalik Dear Matthias, maybe you have heard of Nerd Fonts. We add a lot of icons the existing programming fonts and did so in the past also with your great font. We do not change the existing glyphs. The resultant patched fonts are distributed by several different packaging systems on all relevant platforms. Maybe you can consider the issue below.
Any answer (negative or positive) is appreciated.

Thank you,

Finii

Just updated mononoki locally to 1.5 but noticed that now the license has a RFN clause (*)

This means that we can not distribute a mononoki Nerd Font anymore, except @madmalik grants us a specific exception.
I guess it would be in mononoki's interrest to not introduce another name for a variant that just adds some more icons.

But for new we need to either rename the font on patching (suggestions welcome) or get an exception (like we had with Fira in the past).

(*) Well, it had an RFN before, but that was not mononoki, astonishingly, probably in error.

@madmalik
Copy link

(*) Well, it had an RFN before, but that was not mononoki, astonishingly, probably in error.

Correct, i had neglected to update the license file, which i now fixed.

This means that we can not distribute a mononoki Nerd Font anymore, except @madmalik grants us a specific exception. I guess it would be in mononoki's interrest to not introduce another name for a variant that just adds some more icons.

I'm fine with you using the name mononoki as part of the name for the Nerd Font version, as long as it is clear from the full name, that this is the Nerd Font version and not the original, for example by adding a suffix such as "NF".

@Finii
Copy link
Collaborator

Finii commented Jan 17, 2023

@madmalik Great, thank you!!

All the names (full, font, and family) will end up as "mononoki Nerd Font" resp "mononoki NF" (for the Windows version to keep the name short).

@Finii Finii closed this as completed in fec5873 Jan 17, 2023
@Finii
Copy link
Collaborator

Finii commented Jan 17, 2023

The resulting naming is as shown below:

$ ./gotta-patch-em-all-font-patcher\!.sh -cj /Mononoki
# [Nerd Fonts]  Filter given, limiting search and patch to pathname pattern '/Mononoki'
# [Nerd Fonts]  Total source fonts found: 4
# [Nerd Fonts]  Release timestamp is Tue, 17 Jan 2023 13:31:00 +0100
# [Nerd Fonts]  Processing font 1/4
# [Nerd Fonts]  Processing font 2/4
# [Nerd Fonts]  Processing font 3/4
# [Nerd Fonts]  Processing font 4/4
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Redistributing line gap of 209 (104 top and 105 bottom)
Redistributing line gap of 209 (104 top and 105 bottom)
Redistributing line gap of 229 (114 top and 115 bottom)
Redistributing line gap of 229 (114 top and 115 bottom)
[...]

$ fontforge name_parser/query_names ../../check-fonts/Mononoki/**/*.ttf  2>/dev/null
Examining 16 font files
 |Filename                                           | | Fullname                                                          | | Family                                                  | | Subfamily                      | | Typogr. Family                           | | Typogr. Subfamily
 |-------------------------------------------------- |-| ------------------------------------------------------------      |-| ------------------------------------------------------- |-| ------------------------------ |-| ---------------------------------------- |-| ----------------------------------------
 |mononoki Bold Nerd Font Complete Mono.ttf          | | mononoki Bold Nerd Font Complete Mono                             | | mononoki Nerd Font Mono                                 | | Bold                           | | mononoki Nerd Font Mono                  | | Bold
 |mononoki Bold Nerd Font Complete Mono Windows Comp | | mononoki Bold Nerd Font Complete Mono Windows Compatible          | | mononoki NFM                                            | | Bold                           | | mononoki NFM                             | | Bold
 |mononoki Bold Nerd Font Complete.ttf               | | mononoki Bold Nerd Font Complete                                  | | mononoki Nerd Font                                      | | Bold                           | | mononoki Nerd Font                       | | Bold
 |mononoki Bold Nerd Font Complete Windows Compatibl | | mononoki Bold Nerd Font Complete Windows Compatible               | | mononoki NF                                             | | Bold                           | | mononoki NF                              | | Bold
 |mononoki BoldItalic Nerd Font Complete Mono.ttf    | | mononoki BoldItalic Nerd Font Complete Mono                       | | mononoki Nerd Font Mono                                 | | Bold Italic                    | | mononoki Nerd Font Mono                  | | BoldItalic
 |mononoki BoldItalic Nerd Font Complete Mono Window | | mononoki BoldItalic Nerd Font Complete Mono Windows Compatible    | | mononoki NFM                                            | | Bold Italic                    | | mononoki NFM                             | | BoldItalic
 |mononoki BoldItalic Nerd Font Complete.ttf         | | mononoki BoldItalic Nerd Font Complete                            | | mononoki Nerd Font                                      | | Bold Italic                    | | mononoki Nerd Font                       | | BoldItalic
 |mononoki BoldItalic Nerd Font Complete Windows Com | | mononoki BoldItalic Nerd Font Complete Windows Compatible         | | mononoki NF                                             | | Bold Italic                    | | mononoki NF                              | | BoldItalic
 |mononoki Italic Nerd Font Complete Mono.ttf        | | mononoki Italic Nerd Font Complete Mono                           | | mononoki Nerd Font Mono                                 | | Italic                         | | mononoki Nerd Font Mono                  | | Italic
 |mononoki Italic Nerd Font Complete Mono Windows Co | | mononoki Italic Nerd Font Complete Mono Windows Compatible        | | mononoki NFM                                            | | Italic                         | | mononoki NFM                             | | Italic
 |mononoki Italic Nerd Font Complete.ttf             | | mononoki Italic Nerd Font Complete                                | | mononoki Nerd Font                                      | | Italic                         | | mononoki Nerd Font                       | | Italic
 |mononoki Italic Nerd Font Complete Windows Compati | | mononoki Italic Nerd Font Complete Windows Compatible             | | mononoki NF                                             | | Italic                         | | mononoki NF                              | | Italic
 |mononoki Regular Nerd Font Complete Mono.ttf       | | mononoki Regular Nerd Font Complete Mono                          | | mononoki Nerd Font Mono                                 | | Regular                        | | mononoki Nerd Font Mono                  | | Regular
 |mononoki Regular Nerd Font Complete Mono Windows C | | mononoki Regular Nerd Font Complete Mono Windows Compatible       | | mononoki NFM                                            | | Regular                        | | mononoki NFM                             | | Regular
 |mononoki Regular Nerd Font Complete.ttf            | | mononoki Regular Nerd Font Complete                               | | mononoki Nerd Font                                      | | Regular                        | | mononoki Nerd Font                       | | Regular
 |mononoki Regular Nerd Font Complete Windows Compat | | mononoki Regular Nerd Font Complete Windows Compatible            | | mononoki NF                                             | | Regular                        | | mononoki NF                              | | Regular

Finii added a commit that referenced this issue Jan 17, 2023
@Finii
Fix Mononoki naming [skip ci]
1d8efb6 
[why]
We get very bad names using the old naming algo:

`mononoki BoldItalic Nerd Font Complete`

Also the typographic subfamily is useless (will not be set bu the old
algo)

[how]
Use `--makegroups` which results in correct fullname
`Mononoki Nerd Font Complete Bold Italic`

Related: #575

Signed-off-by: Fini Jastrow <[email protected]>
@Finii
Copy link
Collaborator

Finii commented Jan 17, 2023

Changed naming algorithm (cant stand the old one any longer)...
Looks so much nicer and cleaner:

Fullname                                                          | | Family                                                  | | Subfamily                      | | Typogr. Family                           | | Typogr. Subfamily
------------------------------------------------------------      |-| ------------------------------------------------------- |-| ------------------------------ |-| ---------------------------------------- |-| ----------------------------------------
Mononoki Nerd Font Complete Bold                                  | | Mononoki Nerd Font                                      | | Bold                           | |                                          | |
Mononoki Nerd Font Complete Mono Bold                             | | Mononoki Nerd Font Mono                                 | | Bold                           | |                                          | |
Mononoki Nerd Font Complete Mono Windows Compatible Bold          | | Mononoki NF Mono                                        | | Bold                           | |                                          | |
Mononoki Nerd Font Complete Windows Compatible Bold               | | Mononoki NF                                             | | Bold                           | |                                          | |
Mononoki Nerd Font Complete Bold Italic                           | | Mononoki Nerd Font                                      | | Bold Italic                    | |                                          | |
Mononoki Nerd Font Complete Mono Bold Italic                      | | Mononoki Nerd Font Mono                                 | | Bold Italic                    | |                                          | |
Mononoki Nerd Font Complete Mono Windows Compatible Bold Italic   | | Mononoki NF Mono                                        | | Bold Italic                    | |                                          | |
Mononoki Nerd Font Complete Windows Compatible Bold Italic        | | Mononoki NF                                             | | Bold Italic                    | |                                          | |
Mononoki Nerd Font Complete Italic                                | | Mononoki Nerd Font                                      | | Italic                         | |                                          | |
Mononoki Nerd Font Complete Mono Italic                           | | Mononoki Nerd Font Mono                                 | | Italic                         | |                                          | |
Mononoki Nerd Font Complete Mono Windows Compatible Italic        | | Mononoki NF Mono                                        | | Italic                         | |                                          | |
Mononoki Nerd Font Complete Windows Compatible Italic             | | Mononoki NF                                             | | Italic                         | |                                          | |
Mononoki Nerd Font Complete Mono Regular                          | | Mononoki Nerd Font Mono                                 | | Regular                        | |                                          | |
Mononoki Nerd Font Complete Mono Windows Compatible Regular       | | Mononoki NF Mono                                        | | Regular                        | |                                          | |
Mononoki Nerd Font Complete Regular                               | | Mononoki Nerd Font                                      | | Regular                        | |                                          | |
Mononoki Nerd Font Complete Windows Compatible Regular            | | Mononoki NF                                             | | Regular                        | |                                          | |

@redactedscribe
Copy link
Author

Just updated mononoki locally to 1.5

@Finii Looking forward to 1.5.

It's unfortunate that, at least via Windows' Settings > Personalization > Fonts, it's only possible to see the Nerd Fonts' version number. It would be useful if the reported version could note the NF version and the original version it is based off:

ApplicationFrameHost_2023-01-17_21-28-10

I'm not sure what the Version 1.001 is, but since there's two version numbers already present, it would appear another could be included ;NF @ Mononoki 1.5 for example. Not a critical change, and I don't know its negative implications, if any, but it'd make understanding which version of an original font that NF is using easier than having to visit NF's repo and click around (unless there's a simpler way)?

Thanks.

@Finii
Copy link
Collaborator

Finii commented Jan 18, 2023

Nerd Font adds ; Nerd Fonts 2.2.2 to the version string of the original font.
So Version 1.001 is what mononoki originally has.

I can only guess why they use that version; it looks like the sfnt revision (a number not a string).
But they set it explicitly.

Even more strange, with mononoki 1.5 they set Version 1.004 🤔

image

image

https://github.com/madmalik/mononoki/blob/main/src/mononoki-Regular.ufo/fontinfo.plist#L58-L61

Hmm, from git blame I assume they just forget to change it with 1.5 and that is still 1.4:

image

So, concluding:
The original font's version is preserved. If you think that version-string is useless not very useful, you need to complain at the original font's repo.

Note: And mononoki's version is rather useful, there are fonts that have 1.000 for all versions 😬

@Finii Finii mentioned this issue Jan 18, 2023
Closed
@redactedscribe
Copy link
Author

@Finii By the sounds of it, it's not possible to rely upon the version string from within a font since many are inaccurate. Anyway, thank you for looking into it.

@redactedscribe
Copy link
Author

redactedscribe commented Jan 18, 2023 •
edited
Loading

@Finii I just updated to 2.3.0 NF fonts and Mononoki's mono font has been renamed from "Mononoki NFM" to "Mononoki NF Mono". Not sure why this was necessary when the other NF fonts on my system still use "NFM" in their name, or perhaps this was a mistake? The past two times NF's Mononoki has updated I've had to fiddle with application font settings to get things working again.

@Finii Finii mentioned this issue Jan 18, 2023
Closed
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
@Finii
Update mononoki to 1.5
16988d6 
Mononoki is now a RFN; but under conditions mentioned in [1]
we can use that name for the patched font.

[1] ryanoasis#575 (comment)

Fixes: ryanoasis#575

Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❲Aa❳ update font version bump
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
4 participants
@madmalik @ryanoasis @Finii @redactedscribe