Some fonts displays double as wide as before #895
Comments
|
I can not see an issue with the non-mono font. Examining reason. |
Am I using the non-mono font? I didn't change VS Code's config between restarts and the font's worked fine for months so I presumed I was using the mono variant. How do I specify the Mono variant in VS Code if you happen to know? |
This is a hotfix for #895, which broke all `Mono` fonts. Sorry :-( Signed-off-by: Fini Jastrow <[email protected]>
|
Thanks for the quick fix. I'm hoping the Scoop bucket will push out the 2.2.1 update as that'll be the least messy way for me to test it. Once it does, I can confirm the fix. |
|
@Finii Good job! I was thinking that was some miss config on my side. 😄 |
Fixed. Thanks! |
|
I think Hack Mono has the same issue? |
|
Hack Mono Looks good at first glance:
@blacktop Please check which version you have. |
|
Looks like I'm still on 2.2.0, I'll try and update, but I think brew hasn't updated it yet? |
The update is here Homebrew/homebrew-cask-fonts@7530545 |
|
Jet Brains Mono doesn't look right after the update. |
|
@adastx can you provide a screenshot? |
|
Here are some screenshots. The issue is more subtle than what people were having before with mono fonts. It's most obvious by looking at the arrow symbol. 2.1.0
2.2.1
Reboot doesn't fix the issue and I can switch back and forth between versions without rebooting. I only need to restart alacritty to see the effect. Also yes, I am sure about the versions. |
|
Ah, you mean vertically?
Or do you mean the green arrow? Are you using |
|
Im using alacritty on arch linux. vertically and the green arrow... |
unlikely if you are on Arch. Hmm. Sure you do not use the |
|
from my alacritty.yml |
Not necessarily. Maybe the source changed or bugs got fixed. |
|
The vertical stuff did change in the source (i.e. JetBrains):
And I guess the green-arrow thing is something about #900 |
|
Ok, thanks for the info. I guess I'll just be sticking to 2.1.0 for now. |
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] With commit 821ac68 Create symbols only font directly from sfd template we have a default width for source fonts without a width (i.e. empty fonts). Unfortunately the detection for 'empty font' is wrong. [how] Reorder the commands such that we have a meaningful calculation. Maybe this has been broken by too many (manual) rebases. Fixes: ryanoasis#895 Reported-by: redactedscribe Signed-off-by: Fini Jastrow <[email protected]>
@Finii My Nerd Fonts are managed by a Scoop bucket and it just pushed out an update for many of the NF fonts, Mononoki included, so I assumed it had been: matthewjberger/scoop-nerd-fonts@dfded9f. After installing the font and restarting the system, at least something has changed because the font in VS Code/Codium now displays double as wide as before:
Not sure why, but other programs seem to be unaffected by this bug, and it can be essentially mitigated in Code/Codium by using
editor.letterSpacing": -5.Also, the other NF fonts just updated display the same double-wide behaviour: Switching to Consolas renders with the correct letter spacing. Maybe Code/Codium has a preference that I've altered which is affecting the NF fonts' rendering, but why not Consolas for example? Hmm.
Originally posted by @redactedscribe in #575 (comment)
The text was updated successfully, but these errors were encountered: