-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use correct scissor rects #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These changes are breaking some games. This PR will remain a draft until the proper solution is found. |
Doesn't only fix lightning intensity but fixes some SFX too! The performance improvement is crazy. On my RTX 3080 performance went from 24~29 fps on 1080p to locked 60fps. Before I needed to play at 720p for 60fps. |
Red dead redemption hangs almost immediately with this PR This is the log sync + Vulkan validations |
RDR is black screen now, but game is running and sounds working |
This has already been fixed, you are using an older build of the PR. |
yes i did, my bad |
Will this be merged? Seems to have no downsides and massively improve emulation in bloodborne |
Did you not see the previous comment? "These changes are breaking some games. This PR will remain a draft until the proper solution is found." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
That's old. These issues have been fixed 2 days ago and the issue is not marked WIP anymore |
It seems to me like you are the one that doesn't know how to read |
Derp, egg on my face XD |
This reverts commit 7d96c9d.
Fixes lightning issues in DS3 and BB.
Thanks @tGecko for finding the root cause.