Skip to content

Use correct scissor rects #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

roamic
Copy link
Collaborator

@roamic roamic commented Sep 29, 2024

Fixes lightning issues in DS3 and BB.

Thanks @tGecko for finding the root cause.

@tGecko
Copy link
Contributor

tGecko commented Sep 29, 2024

oh... my... god

image

image

@roamic
Copy link
Collaborator Author

roamic commented Sep 29, 2024

These changes are breaking some games. This PR will remain a draft until the proper solution is found.

@rafael-57
Copy link
Contributor

rafael-57 commented Sep 29, 2024

image
image

shad_log - Copy.txt

Doesn't only fix lightning intensity but fixes some SFX too!

The performance improvement is crazy. On my RTX 3080 performance went from 24~29 fps on 1080p to locked 60fps. Before I needed to play at 720p for 60fps.

@bigol83
Copy link
Contributor

bigol83 commented Sep 29, 2024

Red dead redemption hangs almost immediately with this PR

This is the log sync + Vulkan validations
shad_log.txt

@tGecko
Copy link
Contributor

tGecko commented Sep 29, 2024

fixes lighting in DS3 as well
image

@roamic roamic marked this pull request as ready for review September 29, 2024 10:25
@roamic roamic changed the title WIP: Use correct scissor rects Use correct scissor rects Sep 29, 2024
@Deathedit
Copy link

RDR is black screen now, but game is running and sounds working
shad_log.txt

@squidbus
Copy link
Collaborator

RDR is black screen now, but game is running and sounds working

This has already been fixed, you are using an older build of the PR.

@Deathedit
Copy link

RDR is black screen now, but game is running and sounds working

This has already been fixed, you are using an older build of the PR.

yes i did, my bad

@yoplat
Copy link

yoplat commented Oct 1, 2024

Will this be merged? Seems to have no downsides and massively improve emulation in bloodborne

@pwnedbygary
Copy link

pwnedbygary commented Oct 1, 2024

Will this be merged? Seems to have no downsides and massively improve emulation in bloodborne

Did you not see the previous comment? "These changes are breaking some games. This PR will remain a draft until the proper solution is found."

Copy link
Contributor

@polybiusproxy polybiusproxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rafael-57
Copy link
Contributor

Will this be merged? Seems to have no downsides and massively improve emulation in bloodborne

Did you not see the previous comment? "These changes are breaking some games. This PR will remain a draft until the proper solution is found."

That's old. These issues have been fixed 2 days ago and the issue is not marked WIP anymore

@yoplat
Copy link

yoplat commented Oct 1, 2024

Will this be merged? Seems to have no downsides and massively improve emulation in bloodborne

Did you not see the previous comment? "These changes are breaking some games. This PR will remain a draft until the proper solution is found."

It seems to me like you are the one that doesn't know how to read

@pwnedbygary
Copy link

Will this be merged? Seems to have no downsides and massively improve emulation in bloodborne

Did you not see the previous comment? "These changes are breaking some games. This PR will remain a draft until the proper solution is found."

That's old. These issues have been fixed 2 days ago and the issue is not marked WIP anymore

Derp, egg on my face XD

@georgemoralis georgemoralis merged commit 7d96c9d into shadps4-emu:main Oct 1, 2024
10 checks passed
@roamic roamic deleted the fix-bb-lighting branch October 2, 2024 05:39
diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.