Skip to content

shader_recompiler: Ignore exec mask for scalar instructions. #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

squidbus
Copy link
Collaborator

@squidbus squidbus commented Jan 8, 2025

Looking at Mesa and other AMD ISA specs, it seems that the EXEC mask does not affect scalar or control flow instructions. This PR adds those to the EXEC ignore checks, as well as the rest of the vector read/write lane instructions since those are also documented to ignore it.

Fixes device loss entering first level in CUSA28193, improves graphics in CUSA05637, probably helps others as well.

@kvicken
Copy link

kvicken commented Jan 8, 2025

Resident Evil 2 still crashes with this error: [Debug] <Critical> scalar_memory.cpp:operator():49: Unreachable code!

Log:
shad_log.txt

@polybiusproxy
Copy link
Contributor

The unreachable you're reporting has nothing to do with what this PR aims to solve. It'll be quite hard to solve that unfortunately.

@StevenMiller123
Copy link
Contributor

image
Fixes device lost crashes in Persona 3 Reload.

@jimbigjim1
Copy link

The unreachable you're reporting has nothing to do with what this PR aims to solve. It'll be quite hard to solve that unfortunately.

You still have to do it eventually. Before you say, I would love to learn how to do it myself but I dont know how to code or where to even start... And Im seeing how even people who know C++ dont understand how the emulator works... It would take years to learn how to fix 1 issue

@georgemoralis georgemoralis merged commit 65f9bbb into shadps4-emu:main Jan 8, 2025
12 checks passed
@squidbus squidbus deleted the fix-exec branch January 27, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants