liverpool: Implement PM4 MEM_SEMAPHORE. #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this different from how #1815 did it? |
Yes, this implements what I believe should be the correct behavior while that PR just emitted a global barrier into the Vulkan command buffer. |
|
Ratchet & Clank to menu |
|
@squidbus Shouldn't the mem_semaphore->Decrement(); call be inside the while loop instead of outside of it? |
No, semaphore waits for value to be greater than 0 (signalling either adds 1 or sets to 1) and then decrements it by 1. |
|
Got it, the code made it look slightly more overcomplicated than it really was, mb |
49 tasks
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
May 12, 2025
This reverts commit a5a1253. Revert "shader_recompiler: Fix image write swizzles. (shadps4-emu#2236)" This reverts commit a51c8c1. Revert "shader_recompiler: Implement shader export formats. (shadps4-emu#2226)" This reverts commit 56f4b8a.
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
May 12, 2025
This reverts commit a5a1253. Revert "shader_recompiler: Fix image write swizzles. (shadps4-emu#2236)" This reverts commit a51c8c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
MEM_SEMAPHOREPM4 packet, which signals or yields for wait on a memory address semaphore value.Used by CUSA01047