Skip to content

Text orientation(position) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blaze6950 opened this issue Apr 15, 2018 · 1 comment
Open

Text orientation(position) #3

blaze6950 opened this issue Apr 15, 2018 · 1 comment
Assignees

Comments

@blaze6950
Copy link

I ran into the problem that if the width of the button is large, the text is not centered on the button, but centered if you count from the end of the logo to the end of the button. Is there any way to fix this? I hope, you understood me
P.S.
I want the text to be centered, like the facebook button
default

@shobhitpuri
Copy link
Owner

@blaze6950 Thanks for requesting this feature.

Observation:
This seems to be the fundamental difference b/w the default Facebook and Google buttons.

  • If you see the default Google button as well, the text is centred from the point where the Google logo boundary ends till the end of the button as shown below (If the length of that part is 500 dp, then see around the 250 dp mark, the 'Google' text is centred).
    screenshot_20180416-122309

  • Facebook's default button seem to centring the text within the whole button. (See around 290 dp mark for the Facebook button, the 'Facebook' text is centred within the whole button and not just the part after the logo)
    screenshot_20180416-122411

Potential Solution:
Adhering to the padding guidelines mentioned on the official Google SignIn button branding guidelines, we can try to decrease the padding on left equal to the width of the Google logo. This would make it appear centred but we'll have to make sure the min padding b/w the logo and the text.
google_button_spec

I will create a feature request and will try to take out time to work on it. Feel free to open a pull request with a fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment