Skip to content

Added ability to center the text in the button #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shobhitpuri
Copy link
Owner

Allow centering text within the whole button instead of just the space other than Google icon. This resolves #3

Copy link

@blaze6950 blaze6950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in java, but I have reviewed the code, no suggestions

@shobhitpuri
Copy link
Owner Author

Thanks for reviewing. Its just I've to release the 1.1.0 version before merging this. I'll merge it after releasing.

@manojahi
Copy link

manojahi commented Aug 5, 2021

What is the status of the PR? its been in this state for a long time.
I really really want to have this in my app.

@shobhitpuri
Copy link
Owner Author

What is the status of the PR? its been in this state for a long time.
I really really want to have this in my app.

Haven't been getting time to fix conflicts and test the changes. Feel free to do them, and I can look at the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text orientation(position)
3 participants