Skip to content

fix(core/toast): toast position works as set in production #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(core/toast): toast position works as set in production #1849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c689b31
Toast position solution 1 with setAttribute
GayatriK2002 Apr 23, 2025
c071926
Removed Position property line
GayatriK2002 Apr 23, 2025
500235f
Create tasty-kiwis-travel.md
nuke-ellington Apr 23, 2025
e726479
Merge branch 'main' into fix-1381/toast-position-fix-in-production-mode
GayatriK2002 Apr 24, 2025
1cc716e
Merge branch 'main' into fix-1381/toast-position-fix-in-production-mode
nuke-ellington Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/tasty-kiwis-travel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@siemens/ix": patch
---

Apply __ix-toast__ position in production

Fixes: #1381
2 changes: 1 addition & 1 deletion packages/core/src/components/toast/toast-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function getToastContainer() {

export function setToastPosition(position: ToastPosition) {
const container = getToastContainer();
container.position = position;
container.setAttribute('position', position);
}

function toast(config: ToastConfig): Promise<ShowToastResult> {
Expand Down
Loading