replace 'daddr' checks with 'is_valid_address()'

[martiuslim]

defined a new function is_valid_address as suggested in #656 to use Rust's ip().is_unspecified() and ip().is_multicast() functions instead of comparing against 0.0.0.0:0

[garious]

Thanks! You'll need to run the latest cargo fmt and cargo +nightly clippy. Looks like fmt will convert some tabs to spaces and clippy should ask you to move those redundant parentheses.

[aeyakovenko]

this looks great! Can you add test as well, something that does a

let bad_address = "0.0.0.0:1".parse().unwrap();
assert!(!Crdt::is_valid_address(bad_address));

for port 0, multicast, unspecified...

[martiuslim]

@garious running cargo fmt causes 59 files to be changed for some reason (although in all of them, my diff tool doesn't show any changes 😮). Should I just run rustfmt on the relevant files changed in this pr? Also, running cargo +nightly clippy didn't flag anything on my machine and finished successfully. Am I doing something wrong?

[garious]

It's possible I'm pickier than Clippy. :) Push the patch with the formatted code and let's see what CI says about it.

[garious]

Looks good, but needs to be rebased.

[solana-grimes]

💔 Unable to automerge due to merge conflict

[solana-grimes]

💔 Unable to automerge due to CI failure

[mvines]

automerge is a little busted right now, haven't had a chance to debug why. I'll keep eye on this PR and merge once CI is green in the meantime

[mvines]

Close, cargo fmt is just unhappy about one trailing space in this patch:

cargo fmt -- --write-mode=check
Diff in /solana/src/crdt.rs at line 1919:
         assert!(!me.alive.contains_key(&node_with_same_addr.id));
         assert!(me.alive[&node_with_diff_addr.id] > 0);
     }
-
+
     #[test]
     fn test_is_valid_address() {
         let bad_address_port = "127.0.0.1:0".parse().unwrap();

[garious]

Will merge in #721 after CI passes.