fix: Adding custom splunk version to supported matrix list #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilgajera-crest
requested review from
mbruzda-splunk and
mkolasinski-splunk
harshilgajera-crest
changed the title
mkolasinski-splunk
previously approved these changes
Mar 21, 2024
|
Converting to draft as we need to check a few diff things as well |
harshilgajera-crest
changed the title
harshilgajera-crest
force-pushed
the
test/python3.9-fx
branch
from
f02f2c3 to
a08f1f1
Compare
This PR removes `artifact-registry` step from the pipeline as we don't need Docker containers with add-on builds in the ghcr.io. It is not used in the infra anywhere. Also clean up README.md. Test run: https://github.com/splunk/splunk-add-on-for-mysql/actions/runs/7669490177 --------- Co-authored-by: kdoroszko-splunk <[email protected]>
We need to merge bug fixes with "squash commit" option so we don't have duplicate commit messages when new release is created.
This PR decommissions use of splunk/addonfactory-get-splunk-package-version-action, replacing it with the direct code. https://splunk.atlassian.net/browse/ADDON-68236 Tested here: https://github.com/splunk/test-addonfactory-repo/actions/runs/7817333993/job/21325041323
This PR removes addonfactory-packaging-toolkit-action from the workflow and replaces it with direct logic. It also skips the step of partitioning so release on GitHub only contains files that are used by the developers. https://splunk.atlassian.net/browse/ADDON-68239 Tested here: https://github.com/splunk/test-addonfactory-repo/actions/runs/7902209078 Example release : https://github.com/splunk/test-addonfactory-repo/releases/tag/v0.7.2
Added parameters to simplify the process of making changes and testing argo related stuff. This change is backwards compatible Tested here: https://github.com/splunk/splunk-add-on-for-cisco-meraki/actions/runs/7979596198 Backwards compatibility https://github.com/splunk/splunk-add-on-for-okta-identity-cloud/actions/runs/7986170413/job/21806162151 staging
Image 2.0.12 uses git 2.39 and 2.0.3 uses 2.32. This error was intoduced with git 2.36. It requires setting up safe directory (probably here is some other way to fix it, but this works) Tested here: - https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/8005834200 - https://github.com/splunk/splunk-add-on-for-cisco-meraki/actions/runs/8005821163
harshilgajera-crest
force-pushed
the
test/python3.9-fx
branch
from
2c3137f to
c102982
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stage to combine splunk versions an use it in modinput test job.
Job in AWS addon where modinut is running successfully with python3.9 (Matrix of 24 jobs 3*8): https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/8431526533
Job in MSCS addon : https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/8431532363