Skip to content

Migrate CacheControl to use java.time.Duration for durations #22545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

Migrate CacheControl to use java.time.Duration for durations #22545

merged 1 commit into from
Mar 8, 2019

Conversation

larsgrefer
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 8, 2019
@larsgrefer larsgrefer force-pushed the feature/cacheControlDuration branch from 1bd1ee0 to 1ceb3fa Compare March 8, 2019 00:41
@jhoeller jhoeller self-assigned this Mar 8, 2019
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 8, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 8, 2019
@jhoeller jhoeller merged commit a98e3f0 into spring-projects:master Mar 8, 2019
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Mar 8, 2019
@jhoeller
Copy link
Contributor

jhoeller commented Mar 8, 2019

Thanks for raising this! Other classes such as ResponseCookie and TaskScheduler are Duration-based already, so CacheControl was really an odd one out.

@larsgrefer larsgrefer mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

Successfully merging this pull request may close these issues.
3 participants
@larsgrefer @jhoeller @spring-projects-issues