Skip to content

Enhance support for java.time types in spring-web #22546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enhance support for java.time types in spring-web #22546

wants to merge 2 commits into from

Conversation

larsgrefer
Copy link
Contributor

@larsgrefer larsgrefer commented Mar 8, 2019 •
edited by jhoeller
Loading

see also #22545 and #22103

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 8, 2019
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Mar 8, 2019
@jhoeller jhoeller self-assigned this Mar 8, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 8, 2019
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 8, 2019
@jhoeller jhoeller modified the milestones: 5.2 M1, 5.2 M2 Mar 13, 2019
@jhoeller jhoeller modified the milestones: 5.2 M2, 5.2 M1 Mar 27, 2019
@jhoeller jhoeller closed this in 4a5b9d3 Apr 2, 2019
@jhoeller
Copy link
Contributor

jhoeller commented Apr 2, 2019

I went with a custom commit that implements these accessors a bit differently, adapting Duration values to the existing storage format rather than going via Duration even for long values. Thanks for the PR and for raising this gap to begin with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

Successfully merging this pull request may close these issues.
4 participants
@larsgrefer @jhoeller @sbrannen @spring-projects-issues