Skip to content

clean useless uses of PINOCCHIO_WITH_CXX11_SUPPORT #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Jan 29, 2025

since C++11 is already enforced in CMakeLists.txt

since C++11 is already enforced in CMakeLists.txt
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@jcarpent jcarpent enabled auto-merge January 29, 2025 15:59
@jcarpent jcarpent merged commit 6c8b80a into stack-of-tasks:devel Jan 29, 2025
23 of 28 checks passed
@nim65s nim65s deleted the cxx11 branch January 30, 2025 15:34
nim65s added a commit to nim65s/robotpkg that referenced this pull request Mar 13, 2025
  ## [3.4.0] - 2025-02-12

  ### Added
  - Add parsing meshes with vertices for MJCF format (stack-of-tasks/pinocchio#2537)

  ### Fixed
  - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option (stack-of-tasks/pinocchio#2526)
  - Fix variable naming in Python (stack-of-tasks/pinocchio#2530)
  - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541)
  - CMake: fix RPATH on macos (stack-of-tasks/pinocchio#2546)
  - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541)
  - Fix mjcf parsing of keyframe qpos with newlines (stack-of-tasks/pinocchio#2535)
  - Fix sites parsing for MJCF format (stack-of-tasks/pinocchio#2548)
  - Fix register `std::shared_ptr<{,Geometry}{Model,Data}>` in bindings (stack-of-tasks/pinocchio#2566)
  - Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` (stack-of-tasks/pinocchio#2564)
nim65s added a commit to nim65s/robotpkg that referenced this pull request Mar 13, 2025
  ## [3.4.0] - 2025-02-12

  ### Added
  - Add parsing meshes with vertices for MJCF format (stack-of-tasks/pinocchio#2537)

  ### Fixed
  - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option (stack-of-tasks/pinocchio#2526)
  - Fix variable naming in Python (stack-of-tasks/pinocchio#2530)
  - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541)
  - CMake: fix RPATH on macos (stack-of-tasks/pinocchio#2546)
  - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541)
  - Fix mjcf parsing of keyframe qpos with newlines (stack-of-tasks/pinocchio#2535)
  - Fix sites parsing for MJCF format (stack-of-tasks/pinocchio#2548)
  - Fix register `std::shared_ptr<{,Geometry}{Model,Data}>` in bindings (stack-of-tasks/pinocchio#2566)
  - Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` (stack-of-tasks/pinocchio#2564)
nim65s added a commit to nim65s/robotpkg that referenced this pull request Mar 13, 2025
  ## [3.4.0] - 2025-02-12

  ### Added
  - Add parsing meshes with vertices for MJCF format (stack-of-tasks/pinocchio#2537)

  ### Fixed
  - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option (stack-of-tasks/pinocchio#2526)
  - Fix variable naming in Python (stack-of-tasks/pinocchio#2530)
  - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541)
  - CMake: fix RPATH on macos (stack-of-tasks/pinocchio#2546)
  - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541)
  - Fix mjcf parsing of keyframe qpos with newlines (stack-of-tasks/pinocchio#2535)
  - Fix sites parsing for MJCF format (stack-of-tasks/pinocchio#2548)
  - Fix register `std::shared_ptr<{,Geometry}{Model,Data}>` in bindings (stack-of-tasks/pinocchio#2566)
  - Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` (stack-of-tasks/pinocchio#2564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants