-
Notifications
You must be signed in to change notification settings - Fork 435
clean useless uses of PINOCCHIO_WITH_CXX11_SUPPORT #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since C++11 is already enforced in CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
jorisv
approved these changes
Jan 29, 2025
jcarpent
approved these changes
Jan 29, 2025
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 13, 2025
## [3.4.0] - 2025-02-12 ### Added - Add parsing meshes with vertices for MJCF format (stack-of-tasks/pinocchio#2537) ### Fixed - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option (stack-of-tasks/pinocchio#2526) - Fix variable naming in Python (stack-of-tasks/pinocchio#2530) - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541) - CMake: fix RPATH on macos (stack-of-tasks/pinocchio#2546) - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541) - Fix mjcf parsing of keyframe qpos with newlines (stack-of-tasks/pinocchio#2535) - Fix sites parsing for MJCF format (stack-of-tasks/pinocchio#2548) - Fix register `std::shared_ptr<{,Geometry}{Model,Data}>` in bindings (stack-of-tasks/pinocchio#2566) - Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` (stack-of-tasks/pinocchio#2564)
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 13, 2025
## [3.4.0] - 2025-02-12 ### Added - Add parsing meshes with vertices for MJCF format (stack-of-tasks/pinocchio#2537) ### Fixed - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option (stack-of-tasks/pinocchio#2526) - Fix variable naming in Python (stack-of-tasks/pinocchio#2530) - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541) - CMake: fix RPATH on macos (stack-of-tasks/pinocchio#2546) - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541) - Fix mjcf parsing of keyframe qpos with newlines (stack-of-tasks/pinocchio#2535) - Fix sites parsing for MJCF format (stack-of-tasks/pinocchio#2548) - Fix register `std::shared_ptr<{,Geometry}{Model,Data}>` in bindings (stack-of-tasks/pinocchio#2566) - Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` (stack-of-tasks/pinocchio#2564)
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 13, 2025
## [3.4.0] - 2025-02-12 ### Added - Add parsing meshes with vertices for MJCF format (stack-of-tasks/pinocchio#2537) ### Fixed - Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option (stack-of-tasks/pinocchio#2526) - Fix variable naming in Python (stack-of-tasks/pinocchio#2530) - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541) - CMake: fix RPATH on macos (stack-of-tasks/pinocchio#2546) - Fix aba explicit template instantiation (stack-of-tasks/pinocchio#2541) - Fix mjcf parsing of keyframe qpos with newlines (stack-of-tasks/pinocchio#2535) - Fix sites parsing for MJCF format (stack-of-tasks/pinocchio#2548) - Fix register `std::shared_ptr<{,Geometry}{Model,Data}>` in bindings (stack-of-tasks/pinocchio#2566) - Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` (stack-of-tasks/pinocchio#2564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since C++11 is already enforced in CMakeLists.txt