Skip to content

clean useless uses of PINOCCHIO_WITH_CXX11_SUPPORT #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Fix aba explicit template instantiation ([#2541](https://github.com/stack-of-tasks/pinocchio/pull/2541))
- Fix mjcf parsing of keyframe qpos with newlines ([#2535](https://github.com/stack-of-tasks/pinocchio/pull/2535))
- Fix sites parsing for MJCF format ([#2548](https://github.com/stack-of-tasks/pinocchio/pull/2548))
- Removed useless uses of `PINOCCHIO_WITH_CXX11_SUPPORT` ([#2564](https://github.com/stack-of-tasks/pinocchio/pull/2564))


## [3.3.1] - 2024-12-13
Expand Down
9 changes: 2 additions & 7 deletions include/pinocchio/bindings/python/fwd.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,8 @@
#include "pinocchio/bindings/python/context.hpp"
#include <eigenpy/eigenpy.hpp>

#ifdef PINOCCHIO_WITH_CXX11_SUPPORT
#include <memory>
#define PINOCCHIO_SHARED_PTR_HOLDER_TYPE(T) ::std::shared_ptr<T>
#else
#include <boost/shared_ptr.hpp>
#define PINOCCHIO_SHARED_PTR_HOLDER_TYPE(T) ::boost::shared_ptr<T>
#endif
#include <memory>
#define PINOCCHIO_SHARED_PTR_HOLDER_TYPE(T) ::std::shared_ptr<T>

namespace pinocchio
{
Expand Down
4 changes: 0 additions & 4 deletions include/pinocchio/codegen/cppadcg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@

#include "pinocchio/autodiff/cppad.hpp"

#ifndef PINOCCHIO_WITH_CXX11_SUPPORT
#error CppADCodeGen requires C++11 or more
#endif

namespace boost
{
namespace math
Expand Down
4 changes: 0 additions & 4 deletions include/pinocchio/container/boost-container-limits.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

#include "pinocchio/macros.hpp"

// #ifndef PINOCCHIO_WITH_CXX11_SUPPORT

#define PINOCCHIO_BOOST_MPL_LIMIT_CONTAINER_SIZE_DEFAULT 30

#ifndef PINOCCHIO_BOOST_MPL_LIMIT_CONTAINER_SIZE
Expand Down Expand Up @@ -37,6 +35,4 @@

#endif

// #endif // ifndef PINOCCHIO_WITH_CXX11_SUPPORT

#endif // ifndef __pinocchio_container_boost_container_limits_hpp__
2 changes: 1 addition & 1 deletion include/pinocchio/eigen-macros.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
#define PINOCCHIO_EIGEN_CONST_CAST(TYPE, OBJ) const_cast<TYPE &>(OBJ.derived())

///  \brief Tell if Pinocchio should use the Eigen Tensor Module or not
#if defined(PINOCCHIO_WITH_CXX11_SUPPORT) && EIGEN_VERSION_AT_LEAST(3, 2, 90)
#if EIGEN_VERSION_AT_LEAST(3, 2, 90)
#define PINOCCHIO_WITH_EIGEN_TENSOR_MODULE
#endif

Expand Down
4 changes: 0 additions & 4 deletions include/pinocchio/math/multiprecision.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@

#include "pinocchio/math/fwd.hpp"

#ifndef PINOCCHIO_WITH_CXX11_SUPPORT
#error C++11 compiler required.
#endif

#include <boost/multiprecision/number.hpp>
#include <boost/random.hpp>
#include <Eigen/Dense>
Expand Down
7 changes: 0 additions & 7 deletions include/pinocchio/multibody/liegroup/liegroup-base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,7 @@

namespace pinocchio
{
#ifdef PINOCCHIO_WITH_CXX11_SUPPORT
constexpr int SELF = 0;
#else
enum
{
SELF = 0
};
#endif

#define PINOCCHIO_LIE_GROUP_PUBLIC_INTERFACE_GENERIC(Derived, TYPENAME) \
typedef LieGroupBase<Derived> Base; \
Expand Down
Loading