-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
refactor(es/react): Split jsx into automatic/classic #10616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7d2533f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary reason for early directive parsing is that configuration directives in code comments may override settings from .swcrc.
We require all relevant options to be finalized before entering automatic/classic passes to ensure stability during transformation.
Longer-term, we'll move the classic pass earlier in the processing pipeline.
5f7a58d
to
6955145
Compare
Roadmap:
|
crates/swc/tests/tsc-references/jsxJsxsCjsTransformCustomImportPragma.2.minified.js
Outdated
Show resolved
Hide resolved
crates/swc/tests/tsc-references/jsxJsxsCjsTransformCustomImportPragma.2.minified.js
Outdated
Show resolved
Hide resolved
f36178e
to
a833d6c
Compare
Are you fine with using |
I'll introduce the breaking change in Step 3 when switching the default JSX runtime. Given that a breaking change is unavoidable regardless, It's OK to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
CodSpeed Performance ReportMerging #10616 will degrade performances by 21.98%Comparing Summary
Benchmarks breakdown
|
No description provided.