Skip to content

refactor(es/react): Set automatic as default jsx runtime #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 24, 2025
Merged

refactor(es/react): Set automatic as default jsx runtime #10688

merged 8 commits into from
Jun 24, 2025
+5,056 −1,705

Conversation

magic-akari
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d172396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari magic-akari changed the base branch from main to dev June 23, 2025 13:12
@magic-akari
Copy link
Member Author

Roadmap:

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10688 will not alter performance

Comparing magic-akari:refactor/automatic-default (d172396) with dev (8e92afa)

Summary

✅ 140 untouched benchmarks

@magic-akari
Copy link
Member Author

This PR aligns SWC with Babel 8 and introduces a breaking change. We should make downstream users aware of this.
CC @hardfist @GiveMe-A-Name @chenjiahan

magic-akari
magic-akari commented Jun 23, 2025
View reviewed changes
crates/swc/tests/tsc-references/checkJsxChildrenProperty10.2.minified.js
return <div>My Button</div>;
}, Button;
}();
<div> <h2> Hello </h2> <h1> world </h1></div>, <div> <h2> Hello </h2> {function(user) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWC minifier doesn't process JSX anyway.

@magic-akari magic-akari marked this pull request as ready for review June 23, 2025 16:29
@magic-akari magic-akari requested review from a team as code owners June 23, 2025 16:29
@kdy1 kdy1 modified the milestones: Planned, v2 (API cleanup) Jun 23, 2025
@chenjiahan
Copy link
Contributor

Does SWC have a planned milestone for v2?

It seems that Babel 8 has been in development for a long time but has not been released yet.

@kdy1
Copy link
Member

kdy1 commented Jun 24, 2025

There’s no date or ETA yet but you can see v2 milestone (on github)

@chenjiahan
Copy link
Contributor

Get👌 We are also planning Rspack 2.0, which is expected to be released in the first half of 2026

@kdy1 kdy1 changed the title refactor(es/react): Set automatc as default jsx runtime refactor(es/react): Set automatic as default jsx runtime Jun 24, 2025
@kdy1 kdy1 merged commit bc718e1 into swc-project:dev Jun 24, 2025
168 checks passed
kdy1 pushed a commit that referenced this pull request Jun 24, 2025
@magic-akari @kdy1
refactor(es/react): Set automatic as default jsx runtime (#10688)
8a2ac38
@magic-akari magic-akari deleted the refactor/automatic-default branch June 24, 2025 06:36
@magic-akari magic-akari mentioned this pull request Jun 24, 2025
Merged
kdy1 pushed a commit that referenced this pull request Jun 24, 2025
@magic-akari @kdy1
refactor(es/react): Set automatic as default jsx runtime (#10688)
c39fb3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v2 (API cleanup)
Development

Successfully merging this pull request may close these issues.
3 participants
@magic-akari @chenjiahan @kdy1