-
Notifications
You must be signed in to change notification settings - Fork 259
chore: add snapshot testing via md
files
#1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
34a041b
to
14b6694
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
+ Coverage 88.26% 88.38% +0.11%
==========================================
Files 102 102
Lines 10994 10994
==========================================
+ Hits 9704 9717 +13
+ Misses 1290 1277 -13 ☔ View full report in Codecov by Sentry. |
This is now ready. I've also written some docs. |
tusharmath
approved these changes
Feb 3, 2024
md
filesmd
files
md
filesmd
files
auto-merge was automatically disabled
February 3, 2024 10:35
Head branch was pushed to by a user without write access
tusharmath
approved these changes
Feb 3, 2024
/tip 50$ |
🎉🎈 @mogery has been awarded $50! 🎈🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🙋 Bounty claim
💰 Rewarded
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds
tests/execution_spec.rs
, which uses snapshots viainsta
and.md
specs to perform testing, like outlined in #983. It also addstestconv
, an automatic test converter.To-do:
http_spec
graphql_spec
Issue Reference(s):
Fixes #983
/claim #983
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>