runs-table: do not match against exp name #5351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs table, when in comparison mode, is capable of rendering experiment alias and show the full experiment name in the hover text. However, because we are matching regex against experiment name that is not visible without a user interaction, the match is quite surprising and is surprising users. This change removes an ability to match against the experiment name.
bmd3k
approved these changes
Sep 29, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Runs table, when in comparison mode, is capable of rendering experiment alias and show the full experiment name in the hover text. However, because we are matching regex against experiment name that is not visible without a user interaction, the match is quite surprising and is surprising users. This change removes an ability to match against the experiment name.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Runs table, when in comparison mode, is capable of rendering experiment alias and show the full experiment name in the hover text. However, because we are matching regex against experiment name that is not visible without a user interaction, the match is quite surprising and is surprising users. This change removes an ability to match against the experiment name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs table, when in comparison mode, is capable of rendering experiment
alias and show the full experiment name in the hover text. However,
because we are matching regex against experiment name that is not
visible without a user interaction, the match is quite surprising and is
surprising users.
This change removes an ability to match against the experiment name.