Skip to content

runs-table: do not match against exp name #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2021
Merged

runs-table: do not match against exp name #5351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ee25e
runs-table: do not match against exp name
stephanwlee Sep 29, 2021
f1f6dbc
wow test was depending on exp name
stephanwlee Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tensorboard/webapp/runs/views/runs_table/runs_table_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,7 +1525,7 @@ describe('runs_table', () => {
rowling: 'HPz',
tolkien: 'LotR',
});
store.overrideSelector(getRunSelectorRegexFilter, 'ings');
store.overrideSelector(getRunSelectorRegexFilter, 'ing');

const fixture = createComponent(
['rowling', 'tolkien'],
Expand All @@ -1535,7 +1535,6 @@ describe('runs_table', () => {
fixture.detectChanges();
expect(getTableRowTextContent(fixture)).toEqual([
['LotR', 'The Fellowship of the Ring'],
['LotR', 'The Silmarillion'],
]);

// Alias for Harry Potter contains "z". Since legacy Polymer-based
Expand Down
3 changes: 1 addition & 2 deletions tensorboard/webapp/util/matcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface RunMatchable {
*
* - Regex matches name of a run.
* - When `shouldMatchExperiment` is specified, it matches regex against one of
* experiment name, experiment alias, and legacy run name which is generated
* experiment alias, and legacy run name which is generated
* with "<exp alias>/<run name>".
* - An empty regex string always returns true.
* - Invalid regex always return false.
Expand All @@ -51,7 +51,6 @@ export function matchRunToRegex(
const matchables = [runMatchable.runName];
if (shouldMatchExperiment) {
matchables.push(
runMatchable.experimentName,
runMatchable.experimentAlias,
`${runMatchable.experimentAlias}/${runMatchable.runName}`
);
Expand Down
17 changes: 0 additions & 17 deletions tensorboard/webapp/util/matcher_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,6 @@ describe('matcher test', () => {
});

describe('shouldMatchExperiment flag', () => {
it('matches against experimentName when flag is on', () => {
expect(
matchRunToRegex(
buildRunWithName({runName: 'faaaaro', experimentName: 'hello'}),
'lo$',
true
)
).toBe(true);
expect(
matchRunToRegex(
buildRunWithName({runName: 'faaaaro', experimentName: 'hello'}),
'lo$',
false
)
).toBe(false);
});

it('matches against experimentAlias when flag is on', () => {
expect(
matchRunToRegex(
Expand Down