Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

Android package name #33

Closed
iwashi1t opened this issue Sep 12, 2019 · 1 comment · Fixed by #34
Closed

Android package name #33

iwashi1t opened this issue Sep 12, 2019 · 1 comment · Fixed by #34
Labels
help wanted Extra attention is needed

Comments

@iwashi1t
Copy link

The Android package name com.reactlibrary is too general, so can you change it to something else? (e.g. me.uport)

Duplicate error has occurred when used with a library with the same package name com.reactlibrary.
@mirceanis
Copy link
Contributor

mirceanis commented Sep 12, 2019 •
edited
Loading

You are probably right, and the package name could be changed.
We'll add this to the backlog but if you are in a hurry, a PR to fix this would be very welcome.

Thank you for reporting this.

@mirceanis mirceanis added the help wanted Extra attention is needed label Sep 12, 2019
vmadalin added a commit to vmadalin/react-native-uport-signer that referenced this issue Sep 13, 2019
@vmadalin
Fix uport-project#33 rename android package
706bf41
@vmadalin vmadalin mentioned this issue Sep 13, 2019
Merged
mirceanis added a commit that referenced this issue Sep 13, 2019
@mirceanis
Merge pull request #34 from VMadalin/vm/fix/#33
14c144f 
Change android package to com.uport.signer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change android package to com.uport.signer vmadalin/react-native-uport-signer
2 participants
@mirceanis @iwashi1t