Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

Change android package to com.uport.signer #34

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Change android package to com.uport.signer #34

merged 3 commits into from
Sep 13, 2019

Conversation

vmadalin
Copy link
Contributor

@vmadalin vmadalin commented Sep 13, 2019 •
edited by mirceanis
Loading

Description

Fixed #33 changing the android package name with me.uport.rnsigner that is more specific for this Organisation project than the simpler **.uport or uport.

mirceanis
mirceanis suggested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. That was fast!
I made some suggestions to use me.uport.rnsigner as the package and a request to remove a method that is not needed in recent versions of RN

mirceanis
mirceanis suggested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updated package name.
This is still showing the createJSModules method which should be removed to work with modern versions of react-native

@mirceanis mirceanis merged commit 14c144f into uport-project:develop Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android package name
2 participants
@vmadalin @mirceanis