-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add chain.blockTime
#3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 99f7954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 1023 1023
Lines 79869 79874 +5
Branches 3446 3448 +2
=======================================
+ Hits 79567 79572 +5
Misses 283 283
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
@@ -4,6 +4,7 @@ import { formatters } from './formatters.js' | |||
import { serializers } from './serializers.js' | |||
|
|||
export const chainConfig = { | |||
blockTime: 2_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blockTime: 2_000, | |
blockTime: 1_000, |
celo's block time is 1 second https://specs.celo.org/deployments.html?highlight=second#mainnet
Chains are becoming a lot faster than Mainnet these days (OP Stack, ZKsync, etc). We should be adjusting the default polling interval/cache time to suit.