Skip to content

Zarr data types refactor compatibility #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Zarr data types refactor compatibility #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe84ad6
un-xfail some big endian tests
TomNicholas Jun 17, 2025
21986fa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 17, 2025
7a2e4f0
update minimum require zarr version to the as-yet-unreleased zarr 3.1.0
TomNicholas Jun 17, 2025
81dbe02
Merge branch 'zarr-data-types-refactor-compat' of https://github.com/…
TomNicholas Jun 17, 2025
ed36be6
Revert "update minimum require zarr version to the as-yet-unreleased …
TomNicholas Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions virtualizarr/tests/test_parsers/test_fits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@

@requires_kerchunk
@requires_network
@pytest.mark.xfail(
reason="Big endian not yet supported by zarr-python 3.0"
) # https://github.com/zarr-developers/zarr-python/issues/2324
def test_open_hubble_data():
# data from https://registry.opendata.aws/hst/
file_url = "s3://stpubdata/hst/public/f05i/f05i0201m/f05i0201m_a1f.fits"
Expand Down
1 change: 0 additions & 1 deletion virtualizarr/tests/test_parsers/test_hdf/test_hdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ def test_coord_names(
) as vds:
assert set(vds.coords) == {"lat", "lon"}

@pytest.mark.xfail(reason="Requires Zarr v3 big endian dtype support")
def test_big_endian(
self,
big_endian_dtype_hdf5_file,
Expand Down
7 changes: 0 additions & 7 deletions virtualizarr/tests/test_parsers/test_netcdf3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import pytest
import xarray as xr
import xarray.testing as xrt

Expand All @@ -10,9 +9,6 @@


@requires_scipy
@pytest.mark.xfail(
reason="Big endian not yet supported by zarr-python 3.0"
) # https://github.com/zarr-developers/zarr-python/issues/2324
def test_read_netcdf3(netcdf3_file, array_v3_metadata):
filepath = str(netcdf3_file)
store = obstore_local(file_url=filepath)
Expand All @@ -37,9 +33,6 @@ def test_read_netcdf3(netcdf3_file, array_v3_metadata):


@requires_network
@pytest.mark.xfail(
reason="Big endian not yet supported by zarr-python 3.0"
) # https://github.com/zarr-developers/zarr-python/issues/2324
def test_read_http_netcdf3(array_v3_metadata):
file_url = "https://github.com/pydata/xarray-data/raw/master/air_temperature.nc"
store = obstore_http(file_url=file_url)
Expand Down
Loading