Skip to content

gitlint complains of apostrophe in user name #10152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
galak opened this issue Sep 21, 2018 · 0 comments
Closed

gitlint complains of apostrophe in user name #10152

galak opened this issue Sep 21, 2018 · 0 comments
Assignees
@nashif
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@galak
Copy link
Collaborator

galak commented Sep 21, 2018

In:

#10145

The user's name was:

Signed-off-by: Bryan O'Donoghue [email protected]

And gitlint complained:

1: UC2 Signed-off-by: must have a full name
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Sep 21, 2018
@galak galak added the priority: low Low impact/importance bug label Sep 21, 2018
nashif added a commit to nashif/zephyr that referenced this issue Sep 21, 2018
@nashif
gitlint: accept "'" in committer names
fa0f380 
Allow "'" in names, for example xxx O'xxx.

Fixes zephyrproject-rtos#10152

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif mentioned this issue Sep 21, 2018
Merged
nashif added a commit that referenced this issue Sep 21, 2018
@nashif
gitlint: accept "'" in committer names
0f55538 
Allow "'" in names, for example xxx O'xxx.

Fixes #10152

Signed-off-by: Anas Nashif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nashif @galak