-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Master+atsamd21 xpro #10145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master+atsamd21 xpro #10145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10145 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 213 213
Lines 26148 26148
Branches 5636 5636
=======================================
Hits 13749 13749
Misses 10145 10145
Partials 2254 2254 Continue to review full report at Codecov.
|
I had this error with gitlint too Commit bbeb3f2e0c: But my SOB looks like this for both patches I guess it's the apostrophe the tool is choking on - which is common for Irish names BTW. |
Confirmed gitlint wants "Bryan ODonoghue" not "Bryan O'Donoghue" ... my given name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few copyright/license headers missing. Otherwise at first glance this looks good.
Yeah, we should open an issue to get gitlint fixed not to flag that. Can you see if you can address the other commit message (I think it was a little too long). |
@dbkinder can you take a look at the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
67bc38c
to
acd8932
Compare
@bryanodonoghue once you push the other fixes we should be able to merge this! |
Fix compilation of sam0 serial driver on sam21dj18a by converting _U() to __U() and _L() to __L() in sam21dj18a.h. Signed-off-by: Bryan O'Donoghue <[email protected]>
This patch adds support of the SAMD21 XPlained board. The board has a similar pinout to the SAMD20 XPlained with a different pin-mapping. Signed-off-by: Bryan O'Donoghue <[email protected]>
acd8932
to
ebce1b6
Compare
Hello.
This PR enables Zephyr on the SAM D21 Xplained Pro. The base footprint of the D20 Xplained and D21 Xplained is the same, however, the SAMD21 has a different pinout and different I/O connections as a result and therefore requires a new board port to enable Zephyr.
The first patch fixes a simple compile error
The second patch lands the new board port.
Note I'm open to breaking up the second patch into smaller components, I'm landing it as one patch here since that is how the SAM D20 landed, so I'm assuming you guys prefer it that way.
If not let me know and I can churn into smaller pieces.