Skip to content

Master+atsamd21 xpro #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Conversation

0xB0D
Copy link
Contributor

@0xB0D 0xB0D commented Sep 21, 2018

Hello.

This PR enables Zephyr on the SAM D21 Xplained Pro. The base footprint of the D20 Xplained and D21 Xplained is the same, however, the SAMD21 has a different pinout and different I/O connections as a result and therefore requires a new board port to enable Zephyr.

The first patch fixes a simple compile error
The second patch lands the new board port.

Note I'm open to breaking up the second patch into smaller components, I'm landing it as one patch here since that is how the SAM D20 landed, so I'm assuming you guys prefer it that way.

If not let me know and I can churn into smaller pieces.

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #10145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10145   +/-   ##
=======================================
  Coverage   52.58%   52.58%           
=======================================
  Files         213      213           
  Lines       26148    26148           
  Branches     5636     5636           
=======================================
  Hits        13749    13749           
  Misses      10145    10145           
  Partials     2254     2254

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48434b...ebce1b6. Read the comment docs.

@0xB0D
Copy link
Contributor Author

0xB0D commented Sep 21, 2018

I had this error with gitlint too

Commit bbeb3f2e0c:
1: UC2 Signed-off-by: must have a full name

But my SOB looks like this for both patches
Signed-off-by: Bryan O'Donoghue [email protected]

I guess it's the apostrophe the tool is choking on - which is common for Irish names BTW.

@0xB0D
Copy link
Contributor Author

0xB0D commented Sep 21, 2018

Confirmed gitlint wants "Bryan ODonoghue" not "Bryan O'Donoghue" ... my given name.
Can you guys commit as-is without having to change my SOB ?

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few copyright/license headers missing. Otherwise at first glance this looks good.

@galak
Copy link
Collaborator

galak commented Sep 21, 2018

Confirmed gitlint wants "Bryan ODonoghue" not "Bryan O'Donoghue" ... my given name.
Can you guys commit as-is without having to change my SOB

Yeah, we should open an issue to get gitlint fixed not to flag that.

Can you see if you can address the other commit message (I think it was a little too long).

@galak
Copy link
Collaborator

galak commented Sep 21, 2018

@dbkinder can you take a look at the docs.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@0xB0D 0xB0D force-pushed the master+atsamd21_xpro branch from 67bc38c to acd8932 Compare September 21, 2018 15:41
@galak
Copy link
Collaborator

galak commented Sep 21, 2018

@bryanodonoghue once you push the other fixes we should be able to merge this!

Fix compilation of sam0 serial driver on sam21dj18a by converting _U()
to __U() and _L() to __L() in sam21dj18a.h.

Signed-off-by: Bryan O'Donoghue <[email protected]>
This patch adds support of the SAMD21 XPlained board. The board has a
similar pinout to the SAMD20 XPlained with a different pin-mapping.

Signed-off-by: Bryan O'Donoghue <[email protected]>
@galak galak force-pushed the master+atsamd21_xpro branch from acd8932 to ebce1b6 Compare September 21, 2018 23:00
@galak galak merged commit 674ccd3 into zephyrproject-rtos:master Sep 22, 2018
@0xB0D 0xB0D deleted the master+atsamd21_xpro branch September 22, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants