Skip to content

717aa9cea7 broke use of dtc 1.4.6 #12685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pabigot opened this issue Jan 24, 2019 · 0 comments · Fixed by #12694
Closed

717aa9cea7 broke use of dtc 1.4.6 #12685

pabigot opened this issue Jan 24, 2019 · 0 comments · Fixed by #12694
Assignees
@galak
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Jan 24, 2019 

lilith[773]$ git one | head -1
* 717aa9cea7 (HEAD) [Fri Jan 18 14:10:04 2019 -0600] cmake: dts: Tweak warning flags for unit_address check
lilith[774]$ dtc --version
Version: DTC 1.4.6
lilith[775]$ pwd
/mnt/devel/external/zephyr/samples/sensor/sht3xd/ble400
lilith[776]$ rm -rf * && cmake -GNinja -DBOARD=nrf51_ble400 ..
Zephyr version: 1.13.99
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.6.7", minimum required is "3.4") 
-- Selected BOARD nrf51_ble400
Parsing Kconfig tree in /mnt/devel/external/zephyr/Kconfig
Loading /mnt/devel/external/zephyr/boards/arm/nrf51_ble400/nrf51_ble400_defconfig as base
Merging /mnt/devel/external/zephyr/samples/sensor/sht3xd/prj.conf
Configuration written to '/mnt/devel/external/zephyr/samples/sensor/sht3xd/ble400/zephyr/.config'
-- Loading /mnt/devel/external/zephyr/boards/arm/nrf51_ble400/nrf51_ble400.dts as base
-- Overlaying /mnt/devel/external/zephyr/dts/common/common.dts
-- Overlaying /mnt/devel/external/zephyr/samples/sensor/sht3xd/nrf51_ble400.overlay
FATAL ERROR: Unrecognized check name "unique_unit_address"
CMake Error at /mnt/devel/external/zephyr/cmake/dts.cmake:103 (message):
  command failed with return code: 1
Call Stack (most recent call first):
  /mnt/devel/external/zephyr/cmake/app/boilerplate.cmake:406 (include)
  CMakeLists.txt:8 (include)


-- Configuring incomplete, errors occurred!
@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Jan 24, 2019
@nashif nashif added the priority: medium Medium impact/importance bug label Jan 24, 2019
galak added a commit to galak/zephyr that referenced this issue Jan 24, 2019
@galak
cmake: dts: Fix building with dtc 1.4.6
7596a5d 
dtc 1.4.6 doesn't support the -Wno-unique_unit_address flag.  We need to
check that the flag is supported before using it on pre dtc-1.4.7
versions.

Fixes zephyrproject-rtos#12685

Signed-off-by: Kumar Gala <[email protected]>
@galak galak mentioned this issue Jan 24, 2019
Merged
nashif pushed a commit that referenced this issue Jan 25, 2019
@galak @nashif
cmake: dts: Fix building with dtc 1.4.6
67e098a 
dtc 1.4.6 doesn't support the -Wno-unique_unit_address flag.  We need to
check that the flag is supported before using it on pre dtc-1.4.7
versions.

Fixes #12685

Signed-off-by: Kumar Gala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galak galak

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: dts: Fix building with dtc 1.4.6 galak/zephyr
3 participants
@nashif @pabigot @galak