Skip to content

cmake: dts: Fix building with dtc 1.4.6 #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

galak
Copy link
Collaborator

@galak galak commented Jan 24, 2019

dtc 1.4.6 doesn't support the -Wno-unique_unit_address flag. We need to
check that the flag is supported before using it on pre dtc-1.4.7
versions.

Fixes #12685

Signed-off-by: Kumar Gala [email protected]

dtc 1.4.6 doesn't support the -Wno-unique_unit_address flag.  We need to
check that the flag is supported before using it on pre dtc-1.4.7
versions.

Fixes zephyrproject-rtos#12685

Signed-off-by: Kumar Gala <[email protected]>
Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested personally but looks right.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@14dcd13). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #12694   +/-   ##
=========================================
  Coverage          ?   53.86%           
=========================================
  Files             ?      243           
  Lines             ?    27768           
  Branches          ?     6749           
=========================================
  Hits              ?    14958           
  Misses            ?    10002           
  Partials          ?     2808

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14dcd13...7596a5d. Read the comment docs.

@nashif nashif merged commit 67e098a into zephyrproject-rtos:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

717aa9cea7 broke use of dtc 1.4.6
4 participants