Skip to content

[Coverity CID :190978]Control flow issues in /drivers/spi/spi_intel.c #13842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Feb 27, 2019 · 2 comments
Closed

[Coverity CID :190978]Control flow issues in /drivers/spi/spi_intel.c #13842

mandarcthorat1 opened this issue Feb 27, 2019 · 2 comments
Assignees
@galak
Labels
area: Drivers area: SPI SPI bus bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/spi/spi_intel.c
Category: Control flow issues
Function: push_data
Component: Drivers
CID: 190978
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 27, 2019
@galak galak added priority: medium Medium impact/importance bug area: SPI SPI bus labels Feb 27, 2019
@galak galak self-assigned this Feb 27, 2019
galak added a commit to galak/zephyr that referenced this issue Feb 27, 2019
@galak
spi: spi_intel: Fix missing 'break' in case
6cb0de1 
Coverity scan found issue with a missing 'break' statement.  Fix
push_data by adding the break after handling the 1 byte case.

Coverity CID: 190978
Fixes zephyrproject-rtos#13842

Signed-off-by: Kumar Gala <[email protected]>
@galak galak mentioned this issue Feb 27, 2019
Merged
@pfalcon
Copy link
Collaborator

pfalcon commented Feb 28, 2019

Also handled by @maxxlife in #13806, which was earlier. (@maxxlife, that shows that if you start working on a ticket, it makes sense to add a comment to it about that).

@maxxlife
Copy link
Contributor

maxxlife commented Feb 28, 2019 •
edited
Loading

Also handled by @maxxlife in #13806, which was earlier. (@maxxlife, that shows that if you start working on a ticket, it makes sense to add a comment to it about that).

Ok. I just didn't see that thread.

@maxxlife maxxlife mentioned this issue Feb 28, 2019
Closed
andrewboie pushed a commit that referenced this issue Feb 28, 2019
@galak @andrewboie
spi: spi_intel: Fix missing 'break' in case
846dfd4 
Coverity scan found issue with a missing 'break' statement.  Fix
push_data by adding the break after handling the 1 byte case.

Coverity CID: 190978
Fixes #13842

Signed-off-by: Kumar Gala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galak galak

Labels
area: Drivers area: SPI SPI bus bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pfalcon @maxxlife @galak @mandarcthorat1