drivers: spi: added break in switch of function push_data

[maxxlife]

I added a new break statement in case 1

Before I thought that maybe it is good idea to make case 1 by default,
but it will be useless, so I decided to add break in case 1 instead of
making it by default:
Now switch part of the function must run like classic switch.

Coverity-CID: 190978
Fixes: #13842

Signed-off-by: Maksim Masalski [email protected]

[codecov-io]

Codecov Report

Merging #13806 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13806      +/-   ##
==========================================
+ Coverage   52.26%    52.3%   +0.03%     
==========================================
  Files         307      307              
  Lines       45410    45410              
  Branches    10504    10504              
==========================================
+ Hits        23734    23750      +16     
+ Misses      16887    16875      -12     
+ Partials     4789     4785       -4

Impacted Files	Coverage Δ
subsys/testsuite/ztest/src/ztest.c	72.72% <0%> (+7.43%)	⬆️
subsys/testsuite/ztest/include/ztest_assert.h	77.77% <0%> (+38.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd65ed8...5a4015e. Read the comment docs.

[pfalcon]

Thanks for the patch.

A correct commit title would be:

drivers: spi: Added break in switch of function push_data

Regarding reference to Coverity, we use following syntax (that should be in contrib manual software I hope):

Coverity-CID: 190978

Similarly, we have:

Fixes: #13842

To refer to the bug ticket (and have it automagically closed when the PR is merged - not a useless feature for a project with ~1000 pending issue tickets).

Just add those before the Signed-off-by line. (You can always grep git log if you forget the exact syntax, that's what I do.)

[maxxlife]

Thanks for the patch.

A correct commit title would be:

drivers: spi: Added break in switch of function push_data

Regarding reference to Coverity, we use following syntax (that should be in contrib manual software I hope):

Coverity-CID: 190978

Similarly, we have:

Fixes: #13842

To refer to the bug ticket (and have it automagically closed when the PR is merged - not a useless feature for a project with ~1000 pending issue tickets).

Just add those before the Signed-off-by line. (You can always grep git log if you forget the exact syntax, that's what I do.)

Understand, will read manual more carefully.

[pfalcon]

Understand, will read manual more carefully

You're doing great actually. I don't know what motivates you to contribute to Zephyr, but I'd say how you do it is an ideal model how a newcomer would start. So, please treat those as friendly hints to make it all even more smooth ;-).

[galak]

Thanks for the PR, got a fix in commit 846dfd4. Closing this PR.