Skip to content

Kconfig.modules needs to be at the top level build folder #14974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carlescufi opened this issue Mar 28, 2019 · 0 comments · Fixed by #14976
Closed

Kconfig.modules needs to be at the top level build folder #14974

carlescufi opened this issue Mar 28, 2019 · 0 comments · Fixed by #14976
Assignees
@hakonfam
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@carlescufi
Copy link
Member

carlescufi commented Mar 28, 2019 •
edited
Loading

Today we are generating Kconfig.modules inside build/zephyr but that is not accurate to what it represents. Since it is a result of running west list on the forest, this should not be tied to zephyr and should instead be at the top-level build/ folder.
Now that we have an actual module in the upstream tree (tinycbor) it only makes sense that we have the list of modules where it belongs.
@carlescufi carlescufi added the bug The issue is a bug, or the PR is fixing a bug label Mar 28, 2019
@carlescufi carlescufi added the priority: medium Medium impact/importance bug label Mar 28, 2019
@hakonfam hakonfam mentioned this issue Mar 28, 2019
Merged
carlescufi added a commit to zephyrproject-rtos/ci-tools that referenced this issue Mar 28, 2019
@carlescufi
check_compliance: Use CMAKE_BINARY_DIR for Kconfig.modules
0f042ca 
Counterpart to Zephyr PR:
zephyrproject-rtos/zephyr#14976

Part of the solution for:
zephyrproject-rtos/zephyr#14974

Signed-off-by: Carles Cufi <[email protected]>
@carlescufi carlescufi mentioned this issue Mar 28, 2019
Merged
nashif pushed a commit to zephyrproject-rtos/ci-tools that referenced this issue Mar 28, 2019
@carlescufi @nashif
check_compliance: Use CMAKE_BINARY_DIR for Kconfig.modules
9f4dc0b 
Counterpart to Zephyr PR:
zephyrproject-rtos/zephyr#14976

Part of the solution for:
zephyrproject-rtos/zephyr#14974

Signed-off-by: Carles Cufi <[email protected]>
ulfalizer pushed a commit to ulfalizer/zephyr that referenced this issue May 13, 2019
@carlescufi @ulfalizer
check_compliance: Use CMAKE_BINARY_DIR for Kconfig.modules
0a8f8d0 
Counterpart to Zephyr PR:
zephyrproject-rtos#14976

Part of the solution for:
zephyrproject-rtos#14974

Signed-off-by: Carles Cufi <[email protected]>
ulfalizer pushed a commit to ulfalizer/zephyr that referenced this issue Oct 23, 2019
@carlescufi @nashif
check_compliance: Use CMAKE_BINARY_DIR for Kconfig.modules
8636cd4 
Counterpart to Zephyr PR:
zephyrproject-rtos#14976

Part of the solution for:
zephyrproject-rtos#14974

Signed-off-by: Carles Cufi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hakonfam hakonfam

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kconfig: Move Kconfig.modules to the root build directory hakonfam/zephyr
2 participants
@hakonfam @carlescufi