kconfig: Move Kconfig.modules to the root build directory #14976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Review history of this comment for details about previous failed status. |
carlescufi
added a commit
to zephyrproject-rtos/ci-tools
that referenced
this pull request
Mar 28, 2019
Counterpart to Zephyr PR: zephyrproject-rtos/zephyr#14976 Part of the solution for: zephyrproject-rtos/zephyr#14974 Signed-off-by: Carles Cufi <[email protected]>
carlescufi
approved these changes
Mar 28, 2019
|
Requires zephyrproject-rtos/ci-tools#41 to pass CI |
Codecov Report
@@ Coverage Diff @@
## master #14976 +/- ##
=======================================
Coverage 52.93% 52.93%
=======================================
Files 309 309
Lines 45251 45251
Branches 10447 10447
=======================================
Hits 23953 23953
Misses 16533 16533
Partials 4765 4765Continue to review full report at Codecov.
|
nashif
pushed a commit
to zephyrproject-rtos/ci-tools
that referenced
this pull request
Mar 28, 2019
Counterpart to Zephyr PR: zephyrproject-rtos/zephyr#14976 Part of the solution for: zephyrproject-rtos/zephyr#14974 Signed-off-by: Carles Cufi <[email protected]>
Currently, the Kconfig.modules file is placed in the build directory relative to the CMake "project". But technically, the file is not project-specific, but global, or build-directory specific. So we move it up one level to the CMAKE_BINARY_DIR instead. Currently, there is only one project, so this change has no effect, but this enables us to have multiple projects in the future, which again enables multi-image builds. Signed-off-by: Sebastian Bøe <[email protected]> Signed-off-by: Håkon Øye Amundsen <[email protected]>
nashif
force-pushed
the
move-kconfig-modules
branch
from
7962470 to
c984c5d
Compare
|
recheck |
nashif
approved these changes
Mar 28, 2019
ulfalizer
pushed a commit
to ulfalizer/zephyr
that referenced
this pull request
May 13, 2019
Counterpart to Zephyr PR: zephyrproject-rtos#14976 Part of the solution for: zephyrproject-rtos#14974 Signed-off-by: Carles Cufi <[email protected]>
ulfalizer
pushed a commit
to ulfalizer/zephyr
that referenced
this pull request
Oct 23, 2019
Counterpart to Zephyr PR: zephyrproject-rtos#14976 Part of the solution for: zephyrproject-rtos#14974 Signed-off-by: Carles Cufi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Kconfig.modules file is placed in the build directory
relative to the CMake "project". But technically, the file is not
project-specific, but global, or build-directory specific.
So we move it up one level to the CMAKE_BINARY_DIR instead. Currently,
there is only one project, so this change has no effect, but this
enables us to have multiple projects in the future, which again
enables multi-image builds.
This fixes #14974
Signed-off-by: Sebastian Bøe [email protected]
Signed-off-by: Håkon Øye Amundsen [email protected]