Clarify in release docs NOT to use github tagging. #14985
Assignees
Labels
bug
The issue is a bug, or the PR is fixing a bug
Comments
|
Not sure if we want to add --tag to 'git describe' or try and make sure we always annotate tags? |
galak
added a commit
to galak/zephyr
that referenced
this issue
Mar 28, 2019
If we tag via github a pre-release we don't get an annotated tag. So the BUILD_VERSION isn't reported correctly. We can fix this via adding --tags to 'git describe'. Fixes zephyrproject-rtos#14985 Signed-off-by: Kumar Gala <[email protected]>
|
We should handle this via tagging by hand and not via github. Want to update https://docs.zephyrproject.org/latest/development_process/release_process.html#tagging to clarify NOT to use github. |
galak
changed the title
galak
added a commit
to galak/zephyr
that referenced
this issue
Mar 28, 2019
Add a note in the tagging section of the release process that explains why using GitHub release process for tags should NOT be done. Fixes zephyrproject-rtos#14985 Signed-off-by: Kumar Gala <[email protected]>
carlescufi
pushed a commit
that referenced
this issue
Mar 29, 2019
Add a note in the tagging section of the release process that explains why using GitHub release process for tags should NOT be done. Fixes #14985 Signed-off-by: Kumar Gala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we use github to tag it doesn't create an 'annotated' tag for a pre-release (not sure if it does for a release).
So we get:
Where
git describe --tagdoes:The text was updated successfully, but these errors were encountered: