Skip to content

doc: Update release_process to clarify about GitHub tagging #14990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

galak
Copy link
Collaborator

@galak galak commented Mar 28, 2019

Add a note in the tagging section of the release process that explains
why using GitHub release process for tags should NOT be done.

Fixes #14985

Signed-off-by: Kumar Gala [email protected]

@galak galak requested a review from dbkinder as a code owner March 28, 2019 16:03
@galak galak requested review from carlescufi, nashif and marc-hb March 28, 2019 16:03
@galak galak added this to the v1.14.0 milestone Mar 28, 2019
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Mar 28, 2019
@codecov-io
Copy link

codecov-io commented Mar 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3c45eb4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14990   +/-   ##
=========================================
  Coverage          ?   52.93%           
=========================================
  Files             ?      309           
  Lines             ?    45266           
  Branches          ?    10451           
=========================================
  Hits              ?    23960           
  Misses            ?    16541           
  Partials          ?     4765

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c45eb4...b4a7a01. Read the comment docs.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 28, 2019

Are you sure this issue affects pre-releases only? This page seems to tell github creates light-weight tags always: https://help.github.com/en/articles/working-with-tags

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 28, 2019

I looked at all tags with git for-each-ref refs/tags. I don't know how they were created but they're all annotated tags except these five light-weight tags:

v1.14.0-rc2
v1.9.1
v1.9.2
zephyr-v1.9.1
zephyr-v1.9.2

@galak
Copy link
Collaborator Author

galak commented Mar 28, 2019

Are you sure this issue affects pre-releases only? This page seems to tell github creates light-weight tags always: help.github.com/en/articles/working-with-tags

Looks like all github tags, will update the note.

Add a note in the tagging section of the release process that explains
why using GitHub release process for tags should NOT be done.

Fixes zephyrproject-rtos#14985

Signed-off-by: Kumar Gala <[email protected]>
@galak galak requested review from carlescufi and marc-hb March 28, 2019 19:41
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very surprising and confusing hence definitely worth mentioning.

@carlescufi carlescufi merged commit c6cce7a into zephyrproject-rtos:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants