tests: remove unused variables #89196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit : 78b1ad9 Re-enable -Wunused-variable for clang. Change restores checking for unused variables, which revealed an unused round_s variable in the code. The unused variable has been removed. Signed-off-by: Mateusz Junkier <[email protected]>
Commit : 78b1ad9 Re-enable -Wunused-variable for clang. Change restores checking for unused variables, which revealed an unused syst_headers_name variable in the code. The unused variable has been removed. Signed-off-by: Mateusz Junkier <[email protected]>
github-actions
bot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
nordic-krch,
npitre,
peter-mitsis and
TaiJuWu
| @@ -287,8 +281,8 @@ static void test_conversion(struct test_rec *t, uint64_t val) | |||
| zassert_true(diff <= maxdiff && diff >= mindiff, | |||
| "Convert %llu (%llx) from %u Hz to %u Hz %u-bit %s\n" | |||
| "result %llu (%llx) diff %lld (%llx) should be in [%lld:%lld]", | |||
| val, val, from_hz, to_hz, t->precision, round_s[t->round], | |||
| result, result, diff, diff, mindiff, maxdiff); | |||
| val, val, from_hz, to_hz, t->precision, t->round, result, result, diff, diff, | |||
There was a problem hiding this comment.
It is not clear to me why round_s would be showing up as unused. However, if it is removed, then the format string above would have to be updated as t->round is an integer, not a string.
There was a problem hiding this comment.
I've just opened #89482 to add validation of strings used in zasserts. Maybe that will fix unused variables case as well as it seems that for some reason formatted string used for zassert is not evaluated when unused variable warning is raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit " 78b1ad9 Re-enable -Wunused-variable for clang. " restores checking for unused variables, which revealed an unused variables in the code.
The unused variable has been removed.