testsuite: ztest: Add validation of zassert strings #89482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aaronemassey,
asemjonovs,
jeremybettis,
nashif and
yperess
jeremybettis
previously approved these changes
May 5, 2025
github-actions
bot
added
area: C Library
github-actions
bot
requested review from
bbolen,
carlocaione,
de-nordic,
galak,
ithinuel,
Laczen,
MaureenHelm,
microbuilder,
stephanosio and
wearyzen
nordic-krch
force-pushed
the
zassert_printf
branch
5 times, most recently
from
3b9fe44 to
e3aa583
Compare
nordic-krch
force-pushed
the
zassert_printf
branch
2 times, most recently
from
7a484a0 to
359c2a7
Compare
|
@nashif is it possible to ignore SonarCloud false negatives? It is reporting a finding in a test but test will fail before that condition may occur. |
nordic-krch
force-pushed
the
zassert_printf
branch
from
359c2a7 to
fa065fc
Compare
github-actions
bot
removed
the
DNM (manifest)
microbuilder
requested changes
May 12, 2025
nordic-krch
force-pushed
the
zassert_printf
branch
from
fa065fc to
220b47a
Compare
microbuilder
previously approved these changes
May 13, 2025
nordic-krch
force-pushed
the
zassert_printf
branch
2 times, most recently
from
851a307 to
0a05318
Compare
Add noncallable printf with string used for ztest assert/assume macros to ensure printf-like argument validation at compile time. Signed-off-by: Krzysztof Chruściński <[email protected]>
After introducing compile time argument validation of strings used in zassert macros multiple warnings appear. Fix all of them. Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix wrong parameter used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix wrong parameters used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix wrong parameter used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix wrong parameter used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix wrong parameter used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix wrong parameter used in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
Update zscilib with cleanup in zassert macros. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
zassert_printf
branch
from
0a05318 to
41cbf16
Compare
|
nashif
approved these changes
May 22, 2025
|
@microbuilder can you re-approve? I had to rebase to resolve conflicts. |
microbuilder
approved these changes
May 22, 2025
|
@nordic-krch can you please have a look at https://github.com/zephyrproject-rtos/zephyr/actions/runs/15189028448 and follow up with the remainder of fixes that seem needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add noncallable printf with string used for ztest assert/assume macros to ensure printf-like argument validation at compile time.