Skip to content

tests: static_idt: Add description and RTM links #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

ajaykish
Copy link
Contributor

@ajaykish ajaykish commented Aug 7, 2018

Add doxygen groups, description and RTM links for
static idt test cases

Signed-off-by: Ajay Kishore [email protected]

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #9321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9321   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files         202      202           
  Lines       25396    25396           
  Branches     5328     5328           
=======================================
  Hits        13337    13337           
  Misses       9960     9960           
  Partials     2099     2099

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ec512...7e79daa. Read the comment docs.

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you changing checkpatch.pl?

@ajaykish
Copy link
Contributor Author

@nashif I was getting below warnings during execution of ./scripts/checkpatch.pl for tests/kernel/static_idt/src/main.c :

tests/kernel/static_idt/src/main.c:92: WARNING:FUNCTION_ARGUMENTS: function definition argument 'exc_divide_error_handler' should also have an identifier name
#92: FILE: tests/kernel/static_idt/src/main.c:92:
+extern void *_EXCEPTION_STUB_NAME(exc_divide_error_handler, IV_DIVIDE_ERROR);

tests/kernel/static_idt/src/main.c:92: WARNING:FUNCTION_ARGUMENTS: function definition argument 'IV_DIVIDE_ERROR' should also have an identifier name
#92: FILE: tests/kernel/static_idt/src/main.c:92:
+extern void *_EXCEPTION_STUB_NAME(exc_divide_error_handler, IV_DIVIDE_ERROR);

So added support function pointers for unnamed function definition in checkpatch.pl.

@nashif
Copy link
Member

nashif commented Aug 13, 2018

So added support function pointers for unnamed function definition in checkpatch.pl.

thats not how it works, you cant just be patching checkpatch whenever you get some warnings or errors, if you think you can improve checkpatch, send a separate patch with the enhancement, otherwise you can raise this issue in the PR as being a false negative for reviewers to ignore it.

@ajaykish ajaykish force-pushed the idt_doc branch 3 times, most recently from 9c9c03a to 7e79daa Compare August 13, 2018 18:26
@ajaykish
Copy link
Contributor Author

@nashif removed the checkpatch related changes, and raised a GH issue #9411 for the warning generated by checkpatch.pl.

@nashif nashif merged commit 648477c into zephyrproject-rtos:master Aug 13, 2018
Add doxygen groups, description and RTM links for
static idt test cases

Signed-off-by: Ajay Kishore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants