Skip to content

checkpatch.pl generates warning messages during execution for tests/kernel/static_idt/src/main.c #9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ajaykish opened this issue Aug 13, 2018 · 1 comment
Closed

checkpatch.pl generates warning messages during execution for tests/kernel/static_idt/src/main.c #9411

ajaykish opened this issue Aug 13, 2018 · 1 comment
Assignees
@nashif
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@ajaykish
Copy link
Contributor

ajaykish commented Aug 13, 2018 •
edited by nashif
Loading

When running checkpatch.pl for tests/kernel/static_idt/src/main.c I see the following warning messages:

tests/kernel/static_idt/src/main.c:92: WARNING:FUNCTION_ARGUMENTS: function definition argument 'exc_divide_error_handler' should also have an identifier name
#92: FILE: tests/kernel/static_idt/src/main.c:92:
+extern void *_EXCEPTION_STUB_NAME(exc_divide_error_handler, IV_DIVIDE_ERROR);

tests/kernel/static_idt/src/main.c:92: WARNING:FUNCTION_ARGUMENTS: function definition argument 'IV_DIVIDE_ERROR' should also have an identifier name
#92: FILE: tests/kernel/static_idt/src/main.c:92:
+extern void *_EXCEPTION_STUB_NAME(exc_divide_error_handler, IV_DIVIDE_ERROR);
@ajaykish ajaykish mentioned this issue Aug 13, 2018
Merged
@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Aug 14, 2018
@nashif nashif self-assigned this Aug 16, 2018
@ajaykish ajaykish mentioned this issue Aug 23, 2018
Closed
ajaykish added a commit to ajaykish/zephyr that referenced this issue Sep 14, 2018
@ajaykish
checkpatch: support function pointers for unnamed function definition
361a55a 
Current unnamed function definition argument does not include function
pointer cases and it reports warnings like:

WARNING: function definition argument 'void' should also have an
identifier name
+unsigned int (*dummy)(void);

Support function pointers for unnamed function arguments.

Fixes zephyrproject-rtos#9411

Signed-off-by: Ajay Kishore <[email protected]>
@nashif
Copy link
Member

nashif commented Nov 22, 2018

going to close this one because checkpatch generates quite a few warnings that are false negatives and we are not going to fix all of those. We will just override them.

@nashif nashif closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nashif @ajaykish