checkpatch: support function pointers for unnamed function definition #9581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9581 +/- ##
=======================================
Coverage 52.15% 52.15%
=======================================
Files 212 212
Lines 25916 25916
Branches 5582 5582
=======================================
Hits 13517 13517
Misses 10149 10149
Partials 2250 2250Continue to review full report at Codecov.
|
|
Reading the description, what does "and it through warnings." means? Perhaps, it can be rewritten for clarity? Also, adding an example to commit message would help. |
ajaykish
force-pushed
the
checkpatch_branch
branch
from
f59649a to
361a55a
Compare
Current unnamed function definition argument does not include function pointer cases and it reports warnings like: WARNING: function definition argument 'void' should also have an identifier name +unsigned int (*dummy)(void); Support function pointers for unnamed function arguments. Fixes zephyrproject-rtos#9411 Signed-off-by: Ajay Kishore <[email protected]>
|
since this is a warning, we are going to ignore it and avoid changing checkpatch, a project not maintained by zephyr. Ideally this should be submitted to the Linux kernel tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current unnamed function definition argument does not include function
pointer cases and it reports warnings like:
WARNING: function definition argument 'void' should also have an identifier name
+unsigned int (*dummy)(void);
Support function pointers for unnamed function arguments.
Fixes #9411
Signed-off-by: Ajay Kishore [email protected]