Revert "sam_e70: enable instruction and data caches on sam_e70" #9688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9688 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 212 212
Lines 25937 25937
Branches 5589 5589
=======================================
Hits 13569 13569
Misses 10122 10122
Partials 2246 2246Continue to review full report at Codecov.
|
This reverts commit c090776. Signed-off-by: Adithya Baglody <[email protected]>
AdithyaBaglody
force-pushed
the
revert_cache
branch
from
1b2b751 to
00a5799
Compare
|
If the recent MPU changes are causing the issue, I am not sure it is the best to revert this patch, at least before some more investigation is done. Some other platforms have cache + MPU enabled (e.g. I.MX RT) and thus might also be affected. On the other hand if the SAM E70 platform is the only one affected, reverting this commit is probably the best to do. |
|
Note that the issues are described in bug #9689. |
nashif
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9647
We need to revert this PR. seems to be breaking a few things inside sam e70.
We can recreate this PR once we understand how the cache is behaving when the MPU is turned on.
Currently all MPU regions always disable the cache. So when we enable the cache in soc init and disable them in the mpu regions init. We might be causing some issue.
Until root cause is found we should revert this.
This reverts commit c090776.