-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Adding in datasource for google_alloydb_cluster #13055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in datasource for google_alloydb_cluster #13055
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
c3857b2
to
de049fb
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
de049fb
to
5654211
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 77 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I think the other datasources should be left in, and the filenames should be fixed
mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/alloydb/data_soruce_alloydb_cluster_test.go
Outdated
Show resolved
Hide resolved
cdc782c
to
09ba57d
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
09ba57d
to
87c2af2
Compare
87c2af2
to
cfb68f4
Compare
Tests analyticsTotal tests: 77 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 77 Click here to see the affected service packages
🟢 All tests passed! View the build log |
6f9f724
Adding in a data source for google_alloydb_cluster
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.