Skip to content

Adding in datasource for google_alloydb_cluster #13055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

NA2047
Copy link
Contributor

@NA2047 NA2047 commented Feb 12, 2025

Adding in a data source for google_alloydb_cluster

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_alloydb_cluster`

@github-actions github-actions bot requested a review from roaks3 February 12, 2025 17:00
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 180 insertions(+))
google-beta provider: Diff ( 4 files changed, 410 insertions(+), 232 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • alloydb

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@NA2047 NA2047 force-pushed the AlloydbClusterDatasource branch from c3857b2 to de049fb Compare February 12, 2025 17:12
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 164 insertions(+))
google-beta provider: Diff ( 4 files changed, 394 insertions(+), 232 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • alloydb
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccAlloydbDatabaseClusterDatasourceConfig
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@NA2047 NA2047 force-pushed the AlloydbClusterDatasource branch from de049fb to 5654211 Compare February 12, 2025 17:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 164 insertions(+))
google-beta provider: Diff ( 4 files changed, 395 insertions(+), 233 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 73
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseClusterDatasourceConfig
  • TestAccAlloydbDatabaseInstanceDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbDatabaseClusterDatasourceConfig [Debug log]
TestAccAlloydbDatabaseInstanceDatasourceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I think the other datasources should be left in, and the filenames should be fixed

@github-actions github-actions bot requested a review from roaks3 February 18, 2025 16:10
@NA2047 NA2047 force-pushed the AlloydbClusterDatasource branch 4 times, most recently from cdc782c to 09ba57d Compare February 18, 2025 16:20
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 154 insertions(+))
google-beta provider: Diff ( 4 files changed, 156 insertions(+), 2 deletions(-))

@NA2047 NA2047 force-pushed the AlloydbClusterDatasource branch from 09ba57d to 87c2af2 Compare February 18, 2025 16:22
@NA2047 NA2047 force-pushed the AlloydbClusterDatasource branch from 87c2af2 to cfb68f4 Compare February 18, 2025 16:24
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 74
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbDatabaseClusterDatasourceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbDatabaseClusterDatasourceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 154 insertions(+))
google-beta provider: Diff ( 4 files changed, 154 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 75
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • alloydb

🟢 All tests passed!

View the build log

@roaks3 roaks3 added this pull request to the merge queue Feb 19, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 6f9f724 Feb 19, 2025
20 checks passed
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025
JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants