moved shared under rules

[ryanhristovski]

• updates the global shared rate limit logic to be under each ratelimit rule rather than the entire ratelimit spec
• removed patching keys and name value in ratelimit rule api
• remove Name field from TrafficFeatures IR, add patch keys to traffic features IR rules
• adds auto-generated Name field to RateLimitRule (this is the key for merging logic)
• updates ratelimit.go logic to work for shared/non-shared fields within each rule

Before:

    rateLimit:
      shared: true
      global:
        rules:
        - clientSelectors:
          - headers:
            - name: x-user-id
              type: Exact
              value: one
          limit:
            requests: 5
            unit: Hour

After:

    rateLimit:
      global:
        rules:
        - clientSelectors:
          - headers:
            - name: x-user-id
              type: Exact
              value: one
          shared: true
          limit:
            requests: 5
            unit: Hour
        - clientSelectors:
          - headers:
            - name: x-user-id
              type: Exact
              value: two
          shared: false
          limit:
            requests: 5
            unit: Hour

---

[codecov]

Codecov Report

Attention: Patch coverage is 64.09266% with 93 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (00ebb2f) to head (a594c36).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/xds/translator/ratelimit.go	78.10%	29 Missing and 15 partials ⚠️
internal/utils/merge.go	0.00%	42 Missing ⚠️
internal/gatewayapi/backendtrafficpolicy.go	50.00%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5944      +/-   ##
==========================================
- Coverage   65.80%   65.74%   -0.06%     
==========================================
  Files         217      217              
  Lines       36056    36195     +139     
==========================================
+ Hits        23726    23796      +70     
- Misses      10854    10909      +55     
- Partials     1476     1490      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arkodg]

why did this get wiped out ?

[arkodg]

may be related to #5967

[arkodg]

why did this get deleted ?

[arkodg]

looks like all the e2e are failing

[arkodg]

why is this needed, imo will never be true

[arkodg]

is sharedRuleName == "" required , or should we rely on stripRuleIndexSuffix to gracefully handle it even when the input is unlikely

[arkodg]

curious why the logic around descriptor creation has increased, shouldnt it be the same and leverage the rule name for descriptor key and value ?