Skip to content

fix: fix topology injector bug #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 6, 2025
Merged

fix: fix topology injector bug #5911

merged 8 commits into from
May 6, 2025

Conversation

jukie
Copy link
Contributor

@jukie jukie commented May 3, 2025

What type of PR is this?

fix: fix topology injector bugs

What this PR does / why we need it:

  • Fix caBundle
  • Fix patch - patches binding resource instead and uses annotation env var

Which issue(s) this PR fixes:

Fixes #5890

Release Notes: No

Signed-off-by: Jukie <[email protected]>
@jukie jukie changed the title fix webhook fix: fix topology injector bug May 3, 2025
@jukie jukie marked this pull request as ready for review May 3, 2025 23:12
@jukie jukie requested a review from a team as a code owner May 3, 2025 23:12
Signed-off-by: Jukie <[email protected]>
Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.43%. Comparing base (7f054a6) to head (0b50125).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/topology_injector.go 50.00% 5 Missing and 1 partial ⚠️
internal/cmd/certgen.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5911      +/-   ##
==========================================
- Coverage   65.45%   65.43%   -0.03%     
==========================================
  Files         216      216              
  Lines       35767    35775       +8     
==========================================
- Hits        23413    23411       -2     
- Misses      10909    10920      +11     
+ Partials     1445     1444       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jukie
Copy link
Contributor Author

jukie commented May 4, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented May 4, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented May 5, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented May 5, 2025

/retest

@arkodg arkodg added this to the v1.4.0 milestone May 5, 2025
@jukie jukie requested review from zirain and arkodg May 5, 2025 22:25
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team May 5, 2025 22:47
@jukie
Copy link
Contributor Author

jukie commented May 6, 2025

/retest

@arkodg arkodg merged commit dde43b9 into envoyproxy:main May 6, 2025
39 of 40 checks passed
@jukie jukie deleted the fix-webhook branch May 6, 2025 04:29
melsal13 referenced this pull request in melsal13/gatewayPersonal May 7, 2025
* fix webhook

Signed-off-by: Jukie <[email protected]>

* lint and test fixes

Signed-off-by: Jukie <[email protected]>

---------

Signed-off-by: Jukie <[email protected]>
Signed-off-by: melsal13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topology injector blocking envoy proxy from starting
3 participants