test: Disable flaky test #3555
Merged
test: Disable flaky test #3555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsPackage flame:
Benchmarks provided with 💙 by Dart Benchmark Action. |
luanpotter
reviewed
Apr 10, 2025
| @@ -173,6 +173,9 @@ void main() { | |||
| expect(blockB.activeCollisions.length, 0); | |||
| }, | |||
| 'correct collisions with many involved collidables': (game) async { | |||
| // Skip this test until it can be made non-flaky. | |||
| return; | |||
There was a problem hiding this comment.
omg dart doesn't have an @Ignore? 😮
There was a problem hiding this comment.
It has a skip: true for normal tests, but this is wrapped in a map to run it through the two different broadphase systems.
wolfenrain
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This disables the flaky test mentioned in #3401, since we don't have a solution for it yet and it interrupts the normal flow of the pipeline.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues