-
Notifications
You must be signed in to change notification settings - Fork 743
Main #10602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: marb2000-patch-1
Are you sure you want to change the base?
Main #10602
Conversation
…nd up in faulty rendering of pane toggle button (microsoft#6780) * Add test ui * Fix issue with margin not updating correctly
* test code * delay load chevron * fix delay load chevron * delay load NVI MenuItemsHost * added visual verification test * updated visual verification files * updated chevron delay load * delete test code * added generated visual verification files * addressed comments
…w. (microsoft#6797) * Attempt to fix issue with exception being thrown during cleanup. * Add test * Add a comment explaining the need for the try catch block
…M API prohibited during DllMain() (microsoft#6826)
* Update WinUI roadmap as feature overview * Comment fixes * More comment fixes
…allow for customizations of the glyph in both places seperately. (microsoft#6831) Expose the chevron margin as a resource to enable cusomtization. Apply chevron foreground color in pointer VSM.
…ransient mode (microsoft#6844) CommandBarFlyout was changed to unconditionally give keyboard focus to the first focusable command when it opens. This breaks the assumption when opening in transient mode that the flyout won't take keyboard focus in that mode. We should only give keyboard focus when opening in standard mode. Also added a test to make sure that this doesn't regress in the future.
* Add space on automation properties name * Add missing L on string
* add micabasealt fallback brushes * update brush names * changes from comments
…lView bring-into-view handling. (microsoft#6899)
) SplitButtonAutomationPeer's Invoke implementation currently just directly calls the Click event handler, which misses the fact that we also have the option of assigning a command to execute. Instead of that, I've made it so we just forward the Invoke implementation to the primary button's automation peer, which will ensure that we do everything a button should do in this case. I also edited the test case using the SplitButton with a command to use Invoke() to test that case as well.
…6897) * sets close and action buttons automation property name * Add test and address comments * Address comments * Add spaces
…ScrollView` (microsoft#6889) * Ensure BringIntoView request is not skipped for direct content of ScrollView * Test for BringIntoView for direct content * Move test to correct location and rename
Following microsoft@664933b we ran into the issue that we now have two different visual state groups targeting the same property (SubItemChevron.Margin), which can cause problems in that one can pave over the other. I've fixed things by duplicating the SubItemChevron so the states for buttons in the primary and secondary items can be managed separately from each other, and toggled visibility of the two based on where the button is located. Also added an automated API test that reproduces the issue without the fix.
… active content fix microsoft#6644' (microsoft#6936)
…indeterminate. (microsoft#6941) ProgressRing should not report the RangeValue pattern when it's indeterminate, as in that case it has no value to report.
Left nav currently has faulty logic to calculate the position in set and size of set, relating to the way in which we count what element we're iterating on. The top nav scenario has the correct logic, and there isn't anything remaining that differentiates the left and top nav here anymore, so I've consolidated both to the same logic. I've added a test scenario to ensure that those are now calculated correctly, as well.
…crosoft#6835) * update test page with cursor positioned menu flyout * changes from comments
"Value" wasn't used as the UIA name associated with HSV since the concern was that "value" could be considered confusing by low-vision accessible users since without the broader context, it wasn't clear it meant the V in HSV rather than just any old value, so we used the equivalent "Brightness" instead. However, UIA names need to contain the full string of any attached label, so I've updated things to read "Value (Brightness)" instead. Also, in cases where there's the context of hue and saturation being present as well, I updated things to just read "Value", for consistency.
…ft#6964) * Fixes narrator now reading which item was grabbed on drag * Add comment
* Fixes Bug 36685596: [WinUI3] [Notepad] Users is unable to navigate to 'Zoom' sub-menu using 'Right' arrow key. * Fixes Bug 36629906: [WinUI2] [Notepad]Focus is not visible on 'View' menu-item, upon activating 'Status bar' & 'Word wrap' present in 'View' menu item. * Fixes Bug 38190286: [WinUI2] [Notepad>Home]: Keyboard focus is not moving in cycle among the 'File', 'Edit' & 'View' menu-items, while navigating via 'Left/Right' arrow keys. * Add comment * Add tests * update handled of key press
Co-authored-by: Marcel Wagner <[email protected]>
* titlebar spec initial * Update specs/TitleBar/titlebar-functional-spec.md Co-authored-by: whiskhub <[email protected]> * Update specs/TitleBar/titleBar-dev-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titleBar-dev-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titleBar-dev-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titleBar-dev-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titleBar-dev-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titleBar-dev-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titlebar-functional-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titlebar-functional-spec.md Co-authored-by: Jay <[email protected]> * Update specs/TitleBar/titlebar-functional-spec.md Co-authored-by: Jay <[email protected]> * formatting changes from comments * update images * add height explanation * address more comments * add notes on header footer naming * contentBefore and contentAfter --------- Co-authored-by: whiskhub <[email protected]> Co-authored-by: Jay <[email protected]>
* Updating icons * Remove source code links
Co-authored-by: Mike Crider <[email protected]>
Updated Bug Template
* Update bug_report.yaml
@cwdsingular please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):