New profile: mullvad-browser

[glitsj16]

Add new profile for mullvad-browser. Requested here and suggested here.

[kmk3]

The only config path used is ~/.config/mullvad-browser-flags.conf.

Where is the user profile stored? Is there no user profile directory?

[glitsj16]

@kmk3

The only config path used is ~/.config/mullvad-browser-flags.conf.
Where is the user profile stored? Is there no user profile directory?

Mullvad Browser stores everything under one directory, including its cache and profile dir. The official download installs under ${HOME}/.local/share/mullvad-browser. The packaged versions in the AUR move everything into /opt/mullvad-browser. Both those paths are whitelisted. I didn't want to explicitly blacklist /opt/mullvad-browser in disable-programs.inc, nothing from /opt is in there. Do you think we should?

[kmk3]

The only config path used is ~/.config/mullvad-browser-flags.conf. Where
is the user profile stored? Is there no user profile directory?

Mullvad Browser stores everything under one directory, including its cache
and profile dir. The official
download installs under
${HOME}/.local/share/mullvad-browser. The packaged versions in the
AUR
move everything into /opt/mullvad-browser.

Are you sure?

From https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=mullvad-browser-bin&id=4aabf2f8085b4712b9cf32eec09a9040f2184ef1#n47:

# copy files from archive
install -dm0755 "$pkgdir/opt/mullvad-browser/"
cp --archive Browser/* "$pkgdir/opt/mullvad-browser/"

# ask it to create profiles in ~
touch "$pkgdir/opt/mullvad-browser/system-install"

Also, how would it handle multiple users in that case? Does it create a
separate /home directory in /opt? Does the install only work for a single
user? Putting user data outside of the user home seems like a bad idea in any
case.

Both those paths are whitelisted.

I'm not sure if you're only talking about /opt, but currently only the .conf
file is whitelisted in ${HOME}; there is no data directory.

I didn't want to explicitly blacklist
/opt/mullvad-browser in disable-programs.inc, nothing from /opt is in there.
Do you think we should?

Well, disable-programs is mostly just configuration/data paths, but if it
indeed can put user data in /opt then blacklisting makes sense to me.

[glitsj16]

@kmk3 Good questions. I'll build those AUR packages again tomorrow and do more extensive testing guided by your remarks/questions. Thanks!

[glitsj16]

@kmk3 UPDATE: there were indeed very significant changes to installation paths and user settings locations compared to when I initially created my version of mullvad-browser.profile! Thanks for (gently) pushing me to review this situation. I've tried to be as verbose in the newly introduced comments as I thought fit to clearly state the differences for both a system-wide installation under /opt and a local installation under ${HOME}. Feel free to make suggestions.

Some additional remarks for reviewers. My assumption of an install under ${HOME}/.local/share/mullvad-browser is based on what we do in torbrowser-launcher.profile and is tested intensively (it's where I have my copy of mullvad-browser installed since it became available). The blacklisting of ${HOME}/UpdateInfo in disable-programs.inc without noblacklisting that path anywhere else needs some clarification. That specific location is only used when installing under /opt. More correctly, when not installing under ${HOME}. Upgrading such a mullvad-browser installation from within the browser will not work anyway - obviously due to the user not having privileges to install files under /opt.

Nothing of the above is set in stone, so feel free to make suggestions!

[glitsj16]

@kmk3 @rusty-snake If you find the time, can you have another look at this? I think it's okay now. Same for #5886.