-
Notifications
You must be signed in to change notification settings - Fork 595
New profile: ledger-live-desktop #6219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
private-cache | ||
# enabling private-dev blocks USB hardware wallets | ||
# private-dev | ||
private-etc @network,@tls-ca,@x11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I' not running firejail from master so my actual profile uses:
private-etc alternatives,ca-certificates,crypto-policies,host.conf,nsswitch.conf,pki,resolv.conf,rpc,selinux,ssl
Networking breaks without these options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good you referenced your private-etc in 0.9.72-format. It translates as
private-etc @network,@tls-ca,@x11,host.conf,rpc
so you'll need to append ,host.conf,rpc
here for master.
3a19016
to
16751b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The profile is missing some vitals. See individual comments.
16751b9
to
f76094a
Compare
Thank you very much for the review @glitsj16. I believe I have addressed all your comments. The updated profile is working for me. Again, I haven't tested the AppImage release of ledger-live. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM.
/opt/ledger-live installation currently sits at 345 MiB, so I decided to whitelist it instead of using private-opt ledger-live, in case future installations grow in size. Not using private-dev was the only way I managed to get my USB wallet to work.
f76094a
to
3dc3adc
Compare
After review in firejail PR: netblue30/firejail#6219
merged, thanks! |
Use one item per line to make them easier to read. Relates to #5646 #5675 #5682 #5691 #5706 #5707 #5710 #5729 #5733 #5761. Relates to #5780 #5847 #5881 #5885 #5887 #5892 #5920 #5934 #5935 #5943. Relates to #5947 #5954 #6007 #6008 #6009 #6013 #6027 #6028 #6030 #6039. Relates to #6083 #6155 #6180 #6181 #6219 #6226 #6227 #6231 #6232 #6233. Relates to #6234 #6235 #6236 #6237 #6241 #6243 #6244 #6245 #6246 #6247. Relates to #6249 #6250 #6251 #6253 #6254 #6255 #6256 #6259 #6293 #6314. Relates to #6315 #6327 #6328 #6333 #6341 #6365 #6422 #6463 #6536 #6549. Relates to #6558 #6577 #6583 #6584 #6585 #6586 #6587 #6588 #6589 #6590. Relates to #6616 #6654 #6669 #6678 #6679.
This is a profile for the Ledger Live wallet.
I based it off the profile offered in #3595, but it needed several tweaks for it to work.
I tested the binary installation in /opt (I use the ledger-live-bin package in AUR). Ledger Live is also offered as an AppImage, but I didn't test that case.
I own a Ledger USB wallet and this profile is working for me.