Skip to content

New profile: ledger-live-desktop #6219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

haplo
Copy link
Contributor

@haplo haplo commented Feb 21, 2024

This is a profile for the Ledger Live wallet.

I based it off the profile offered in #3595, but it needed several tweaks for it to work.

I tested the binary installation in /opt (I use the ledger-live-bin package in AUR). Ledger Live is also offered as an AppImage, but I didn't test that case.

I own a Ledger USB wallet and this profile is working for me.

private-cache
# enabling private-dev blocks USB hardware wallets
# private-dev
private-etc @network,@tls-ca,@x11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I' not running firejail from master so my actual profile uses:

private-etc alternatives,ca-certificates,crypto-policies,host.conf,nsswitch.conf,pki,resolv.conf,rpc,selinux,ssl

Networking breaks without these options.

Copy link
Collaborator

@glitsj16 glitsj16 Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good you referenced your private-etc in 0.9.72-format. It translates as
private-etc @network,@tls-ca,@x11,host.conf,rpc so you'll need to append ,host.conf,rpc here for master.

@haplo haplo force-pushed the ledger-live-desktop branch from 3a19016 to 16751b9 Compare February 21, 2024 22:32
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile is missing some vitals. See individual comments.

@haplo haplo force-pushed the ledger-live-desktop branch from 16751b9 to f76094a Compare February 22, 2024 11:13
@haplo
Copy link
Contributor Author

haplo commented Feb 22, 2024

Thank you very much for the review @glitsj16. I believe I have addressed all your comments. The updated profile is working for me.

Again, I haven't tested the AppImage release of ledger-live.

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM.

/opt/ledger-live installation currently sits at 345 MiB, so I decided to
whitelist it instead of using private-opt ledger-live, in case future
installations grow in size.

Not using private-dev was the only way I managed to get my USB wallet to
work.
@haplo haplo force-pushed the ledger-live-desktop branch from f76094a to 3dc3adc Compare February 28, 2024 21:45
haplo added a commit to haplo/dotfiles that referenced this pull request Feb 29, 2024
@netblue30 netblue30 merged commit 071a5da into netblue30:master Feb 29, 2024
@netblue30
Copy link
Owner

merged, thanks!

@haplo haplo deleted the ledger-live-desktop branch March 1, 2024 11:09
@kmk3 kmk3 changed the title Profile for Ledger Live desktop app New profile: ledger-live-desktop Sep 7, 2024
@kmk3 kmk3 moved this to Done (on RELNOTES) in Release 0.9.74 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

4 participants