Skip to content

New profile: mimetype #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

New profile: mimetype #6247

merged 1 commit into from
Mar 19, 2024

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Mar 2, 2024

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a common CLI utility that is intended to be used on
arbitrary files and I think it's likely that other programs may depend on it.

In which case, it might make sense to avoid blacklisting paths and using
private- commands to avoid potentially breaking common use cases and/or other
tools, especially since the PR enables the profile by default.

Also, note that it reads ~/.local/share/mime, so using private would break
that.

Does it work with the following?

read-only /

If not, how about the following?

read-only ${HOME}
read-only ${RUNUSER}
read-only /tmp

@glitsj16
Copy link
Collaborator Author

glitsj16 commented Mar 2, 2024

Totally forgot about private, I removed it.

read-only /
Warning: cannot create a new user namespace, going forward without it...

So I went for your suggested
read-only ${HOME}
read-only ${RUNUSER}
read-only /tmp

Those work fine.

@kmk3 kmk3 force-pushed the mimetype branch 2 times, most recently from 3f0b308 to 271d394 Compare March 9, 2024 18:03
@glitsj16 glitsj16 merged commit 161318d into netblue30:master Mar 19, 2024
@glitsj16 glitsj16 deleted the mimetype branch March 19, 2024 06:08
@kmk3 kmk3 moved this to Done (on RELNOTES) in Release 0.9.74 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants